Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Config] Throw an exception when using cannotBeEmpty() with numeric or boolean nodes#16816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stof merged 1 commit intosymfony:3.0fromGuilhemN:ISSUE_16812
Dec 5, 2015

Conversation

@GuilhemN
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?yes
Deprecations?no
Tests pass?yes
Fixed tickets#16812
LicenseMIT

@sstok
Copy link
Contributor

👍

@nicolas-grekas
Copy link
Member

👍, as a bug fix for me

@GuilhemN
Copy link
ContributorAuthor

The build failure seems unrelated.

@GuilhemN
Copy link
ContributorAuthor

@nicolas-grekas can you ping the people in charge of theConfig component please ?
Would be good if someone else reviews this PR.

@fabpot
Copy link
Member

👍

1 similar comment
@stof
Copy link
Member

stof commentedDec 5, 2015

👍

@xabbuh
Copy link
Member

👍 (I think we accidentally just removed the methods instead of throwing the exception as it was planed initially, see#15285 (comment)).

@stof
Copy link
Member

stof commentedDec 5, 2015

Thank you @Ener-Getick.

@stofstof merged commitbc20af2 intosymfony:3.0Dec 5, 2015
stof added a commit that referenced this pull requestDec 5, 2015
…h numeric or boolean nodes (Ener-Getick)This PR was merged into the 3.0 branch.Discussion----------[Config] Throw an exception when using cannotBeEmpty() with numeric or boolean nodes| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#16812| License       | MITCommits-------bc20af2 [Config] Throw an exception when using cannotBeEmpty() on numeric or boolean nodes
@GuilhemNGuilhemN deleted the ISSUE_16812 branchDecember 5, 2015 10:14
@fabpotfabpot mentioned this pull requestDec 26, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GuilhemN@sstok@nicolas-grekas@fabpot@stof@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp