NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Filesystem] Recursivly widen non-executable directories#16797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Slamdunk wants to merge1 commit intosymfony:masterfromSlamdunk:filesystem/open-chmod-sub

Closed

[Filesystem] Recursivly widen non-executable directories#16797

Slamdunk wants to merge1 commit intosymfony:masterfromSlamdunk:filesystem/open-chmod-sub

Conversation

Copy link

Contributor

Slamdunk commentedDec 2, 2015

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	none
License	MIT
Doc PR	none

The\FilesystemIterator throws anUnexpectedValueException if the directory is non-executable.

[Filesystem] Recursivly widen non-executable directories

1c9a047

carsonbot added the Status: Needs Review label

Dec 2, 2015

This was referencedDec 2, 2015

Recursivly widen non-executable directoriessymfony/filesystem#5

Closed

Unset callback after stopsymfony/process#12

Closed

jakzal added the Filesystem label

Dec 9, 2015

Copy link

Contributor

jakzal commentedDec 9, 2015

👍

Copy link

Member

fabpot commentedDec 18, 2015

Thank you@Slamdunk.

fabpot added a commit that referenced this pull request

Dec 18, 2015

bug#16797[Filesystem] Recursivly widen non-executable directories (…

0c2f1d9

…Slamdunk)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#16797).Discussion----------[Filesystem] Recursivly widen non-executable directories| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | none| License       | MIT| Doc PR        | noneThe `\FilesystemIterator` throws an `UnexpectedValueException` if the directory is non-executable.Commits-------fb75651 [Filesystem] Recursivly widen non-executable directories

fabpot closed this

Dec 18, 2015

xabbuh pushed a commit to xabbuh/symfony that referenced this pull request

Dec 19, 2015

[Filesystem fix tests on 2.3

caba108

The test introduced insymfony#16797 used the `assertFilePermissions()` methodto test for the expected result. This worked quite well for the PR as itwas submitted for the `master` branch. However, the tests now fail on2.3 as the `FilesystemTestCase` class which contains this method wasintroduced with Symfony 2.4.

xabbuh mentioned this pull request

Dec 19, 2015

[Filesystem] fix tests on 2.3#17071

Merged

xabbuh pushed a commit to xabbuh/symfony that referenced this pull request

Dec 19, 2015

[Filesystem] fix tests on 2.3

9050f67

The test introduced insymfony#16797 used the `assertFilePermissions()` methodto test for the expected result. This worked quite well for the PR as itwas submitted for the `master` branch. However, the tests now fail on2.3 as the `FilesystemTestCase` class which contains this method wasintroduced with Symfony 2.4.

fabpot added a commit that referenced this pull request

Dec 20, 2015

minor#17071[Filesystem] fix tests on 2.3 (Christian Flothmann)

36a5141

This PR was merged into the 2.3 branch.Discussion----------[Filesystem] fix tests on 2.3| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#16797| License       | MIT| Doc PR        |The test introduced in#16797 used the `assertFilePermissions()` methodto test for the expected result. This worked quite well for the PR as itwas submitted for the `master` branch. However, the tests now fail on2.3 as the `FilesystemTestCase` class which contains this method wasintroduced with Symfony 2.4.Commits-------9050f67 [Filesystem] fix tests on 2.3