Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Validator] Fix apc cache service & config#16794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ogizanagi commentedDec 2, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16793 |
| License | MIT |
| Doc PR | - |
jderusse commentedDec 2, 2015
Beware, the new service does not implements the same interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This BC break should trigger a deprecation in previous versions right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The deprecation seems to have been triggered through the newvalidator.mapping.cache.doctrine.apc servicein previous versions...
And this service has been removed in 3.0.
I'm getting lost in the operation.
I think something went wrong during a merge or this wasn't expected to be as it is right now:validator.mapping.cache.doctrine.apc wasn't supposed to be marked as deprecated nor removed IMO.validator.mapping.cache.apc was.
I'm going to makevalidator.mapping.cache.apc an alias of the newvalidator.mapping.cache.doctrine.apc service, but it should probably have been removed instead.
ogizanagi commentedDec 2, 2015
Hmm, you're right. It should be based on |
ogizanagi commentedDec 2, 2015
This PR has been submitted by mistake on |
…g (ogizanagi)This PR was merged into the 3.0 branch.Discussion----------[FrameworkBundle][Validator] Fix apc cache service & config| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16793| License | MIT| Doc PR | -_Keep track of#16794 (comment)_NOTE_: This PR is on standby. If#16822 is merged, this one might probably be closed, as everything will be done during the merge.Commits-------94a1728 [FrameworkBundle][Validator] Fix apc cache service & config