Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Add weak-verbose mode and match against message instead of test name#16789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Bridge/PhpUnit/README.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo: depreaction's -> deprecation's
026b8b7 to62b3effComparenicolas-grekas commentedDec 2, 2015
typos fixed, thanks |
62b3eff toc27975dCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't understand why this preg_match is there. Is it an undocumented feature of the helper ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ah no, it is documented
c27975d tocea79d1Comparecraue commentedDec 2, 2015
👍 |
1 similar comment
stof commentedDec 5, 2015
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we should add those strings as constants esp. since $mode is part of the public api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
consts added
cea79d1 toa670ff1Comparefabpot commentedDec 5, 2015
👍 |
stof commentedDec 5, 2015
Thank you@nicolas-grekas. |
…t message instead of test name (nicolas-grekas)This PR was merged into the 2.8 branch.Discussion----------[PhpUnitBridge] Add weak-verbose mode and match against message instead of test name| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#14475| License | MIT| Doc PR | -This is double a DX bug fix:- the weak-verbose allows showing messages but exit with 0 (see#14475)- matching against $class::$method was a mistake of mine: you can already `--filter` in phpunit to get by-test filtering but you can't select which message should be traced without this change. I stumbled upon this limitation while doing a Symfony 3 migration workshop...Commits-------a670ff1 [PhpUnitBridge] Add weak-verbose mode and match against message instead of test name
…s upper bound" mode (nicolas-grekas)This PR was merged into the 2.8 branch.Discussion----------[PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode| Q | A| ------------- | ---| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16789,#14475| License | MIT| Doc PR | -This is a "new feature" that replaces a "new feature" not yet released but merged into 2.8.1. See#16789.It is way more flexible to be able to specify the upper bound of remaining deprecation notices that you allow in your test suite. This allows lowering this number while deprecations are removed, step after step.ping@wouterj@Tobion@craue@fabpot@stofCommits-------58cd3ee [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
This is double a DX bug fix:
--filterin phpunit to get by-test filtering but you can't select which message should be traced without this change. I stumbled upon this limitation while doing a Symfony 3 migration workshop...