NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Security] These interface allways send deprecated because of wrong inheritance#16775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

xkobal wants to merge1 commit intosymfony:2.8fromxkobal:2.8

Closed

[Security] These interface allways send deprecated because of wrong inheritance#16775

xkobal wants to merge1 commit intosymfony:2.8fromxkobal:2.8

Conversation

Copy link

Contributor

xkobal commentedDec 1, 2015

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#16643
License	MIT
Doc PR

carsonbot added the Status: Needs Review label

Dec 1, 2015

xkobal changed the title~~These interface allways send deprecated because of wrong inheritance~~[Security] These interface allways send deprecated because of wrong inheritance

Dec 1, 2015

xkobal closed this

Dec 1, 2015

xkobal reopened this

Dec 1, 2015

These interface allways send deprecated because of wrong inheritance

341ed6c

(cherry picked from commit02fe171)

Copy link

Contributor

dosten commentedDec 1, 2015

Seems related to#16643

Copy link

ContributorAuthor

xkobal commentedDec 1, 2015

Yes this is the same problem, I haven't seen the issue

Copy link

ContributorAuthor

xkobal commentedDec 1, 2015

Broken tests doesn't seems to come from my PR :-/

linaori mentioned this pull request

Dec 2, 2015

SimpleFormAuthenticationListener Deprecation notice in 2.8#16801

Closed

Copy link

m0ppers commentedDec 2, 2015

I stumbled upon the same issue in#16801 . this pull request is however missing namespace renaming in SimpleFormAuthenticationListener I think (which is needed for#16801). closing my issue now

Copy link

Member

stof commentedDec 5, 2015

The inheritance is done the right way to preserve BC. What should be fixed is that the DebugClassLoader should not trigger a warning for this particular case.

Copy link

Member

stof commentedDec 5, 2015

@nicolas-grekas please check this case for the DebugClassLoader

Copy link

Member

nicolas-grekas commentedDec 5, 2015

Me or anyone else :-)

dosten mentioned this pull request

Dec 26, 2015

[Security] [SimplePreAuthenticatorInterface] Remove divert deprecation message#17138

Closed

peterrehm mentioned this pull request

Jan 9, 2016

[Debug] Fixed erroneous deprecation notice for extended Interfaces#17320

Merged

Copy link

Contributor

peterrehm commentedJan 9, 2016

I just implemented it in#17320.

Copy link

Member

nicolas-grekas commentedJan 11, 2016

Closing in favor of#17320

nicolas-grekas closed this

Jan 11, 2016

nicolas-grekas added a commit that referenced this pull request

Jan 12, 2016

bug#17320[Debug] Fixed erroneous deprecation notice for extended In…

9eb522e

…terfaces (peterrehm)This PR was merged into the 2.8 branch.Discussion----------[Debug] Fixed erroneous deprecation notice for extended Interfaces| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#16643,#16775| License       | MIT| Doc PR        | -Replaces#16775.Commits-------5f4e968 Fixed erroneous deprecation notice for extended Interfaces