Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[3.0] Added getBlockPrefix to FormTypeInterface#16724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
wouterj commentedNov 28, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
Failures seem unrelated to this PR |
@wouterj Can you rebase on the latest |
👍 anyway as the failure is not related to these changes Status: Reviewed |
Thank you@wouterj. |
fabpot added a commit that referenced this pull requestNov 28, 2015
This PR was merged into the 3.0-dev branch.Discussion----------[3.0] Added getBlockPrefix to FormTypeInterface| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Commits-------d834cd3 Added getBlockPrefix to FormTypeInterface
Here's the follow-up:#16749 |
Tobion added a commit that referenced this pull requestNov 29, 2015
…ce (webmozart)This PR was merged into the 3.0-dev branch.Discussion----------[Form] Added getBlockPrefix() to ResolvedFormTypeInterface| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This is the follow-up PR to#16724.If you call `$form->getConfig()->getType()`, all the methods of FormType should be usable. In that sense, ResolvedFormType is the developer-facing version of FormType.It is true that the same could be achieved with `getInnerType()`, but that method should be used in edge cases only as it clutters the code and makes it confusing to read:```php$blockPrefix = $form->getConfig()->getType()->getInnerType()->getBlockPrefix();```Commits-------7e89345 [Form] Added getBlockPrefix() to ResolvedFormTypeInterface
Merged
stof added a commit that referenced this pull requestDec 5, 2015
This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes#16752).Discussion----------[Form] document changes to form type interfaces| Q | A| ------------- | ---| Fixed tickets |#13407,#16024,#16724,#16749| License | MITCommits-------b297a0c [Form] document changes to form type interfaces
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.