Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[profiler] Fix conditional expression to provide a default value#16653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
From the cookbook:<cite>{# the 'link' value set to 'false' means that this panel doesn't show a section in the web profiler (default is 'true'). #}</cite>Simple conditional expression is not enough to provide a default value for the link parameter```twig {% if link %}```xabbuh commentedNov 24, 2015
Shouldn't we rather ensure that the |
krzysiekpiasecki commentedNov 24, 2015
Not necessarily. In principle, data profiles include a larger area, so view of the details is the expected function. Otherwise documentation differs from implementation. |
fabpot commentedNov 25, 2015
ping@javiereguiluz |
stof commentedDec 5, 2015
given that this template is meant to be included by collector templates from any bundle, we cannot ensure it is always defined (except by putting a |
javiereguiluz commentedJan 25, 2016
@xabbuh I think@krzysiekpiasecki is right because according to the documentation:
My only comment for@krzysiekpiasecki is this one: do you think we could replace |
krzysiekpiasecki commentedJan 25, 2016
Yes, you could. |
javiereguiluz commentedJan 25, 2016
@krzysiekpiasecki if you have some more time for this, please change the condition so we can merge this. Thanks a lot! |
fabpot commentedJan 25, 2016
Closing this one, I'm going to create a new PR on 2.3 with@javiereguiluz suggestion. |
This PR was merged into the 2.3 branch.Discussion----------fixed undefined variable| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16653| License | MIT| Doc PR | n/aCommits-------4b21351 fixed undefined variable
…moving inadvertently added links (craue)This PR was merged into the 2.3 branch.Discussion----------[2.3][WebProfilerBundle] fix debug toolbar rendering by removing inadvertently added links| Q | A| ------------- | ---| Branch | 2.3+| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |The debug toolbar was broken by#17527...**before****and after****explanation**If `false` is explicitly passed for `link` then `link | default(true)` would evaluate to `true`, which is not what we want. The correct expression `link is not defined or link` was suggested originally in#16653.Commits-------a0ddfc4 fix debug toolbar rendering by removing inadvertently added links
Fix conditional expression to provide a default value and prevent from the exception
From the cookbook:
{# the 'link' value set to 'false' means that this panel doesn't show a section in the web profiler (default is 'true'). #}
Simple conditional expression is not enough to provide a default value for the link parameter if is missed.
{%iflink %}Custom collector
{{include('@WebProfiler/Profiler/toolbar_item.html.twig') }}WebProfiler/Profiler/toolbar_item.html.twig
{%iflink %}