Test fails seems not related.

ping@webmozart

@symfony/deciders is it possible to have your point of view on this ?

What is the use case for having duplicate choices ?
For duplicate labels, this can be resolved with the existing system by usingchoice_label to build labels for each choice instead of relying on the default behavior

@stof you can check#15606 for cases, there is some. Translations cases, grouped choices with same options in groups.

What is a choice_label is? Can you give a link?

Also it is a bug. To say people than it is "can be resolved by" - it must be documented as feature then. No?

What@stof means and what I agree with is that duplicate choices (what you would get as selected value) makes no sense as you would not be able to distinguish each one anyway. Having the same label can happen and this is possible with thechoice_label option.
The problem in#15606 is that the BC layer for the old choices structure (whenchoices_as_values: false) flips the choices which of course removes all choices which had the same label. So this BC layer must be fixed. So the current solution seems wrong.

@Tobion first of all thanks for review

makes no sense as you would not be able to distinguish each one anyway

Sometimes it is not needed, sometimes business want to show same thing twice, just to increase chance that user select it, or do not miss.

Also as check my case:#15606 (comment).

About choice_label, if you mean something like this:

    public function testCreateViewDuplicateArrayKeyChoiceListValuesWithChoiceLabel()    {        $list = new ArrayKeyChoiceList(            array(                'A' => 'a',                'AA' => 'a'            )        );        $view = $this->factory->createView(            $list,            null,            function ($allChoices, $currentChoiceKey) {                return 'a';            }        );        $this->assertEquals(            new ChoiceListView(                array(                    0 => new ChoiceView('A', 'A', 'a'),                    1 => new ChoiceView('AA', 'AA', 'a')                ),                array()            ),            $view        );    }

It is not working.

The problem in#15606 is that the BC layer for the old choices structure (when choices_as_values: false)
So this BC layer must be fixed

Can you check tests from this PR? For example there is a test that create ArrayKeyChoiceList without second argument, and in this case useChoicesAsValues will be true. It is not only about BC layer as I understand.

Would be nice to hear@webmozart, as contributor of this code.

Hi :) Thanks for working on this! I think this should be fixed in a less intrusive way. See#16685.