Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fix bug in windows detection#16578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kbond commentedNov 17, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16577 |
| License | MIT |
| Doc PR | n/a |
javiereguiluz commentedNov 17, 2015
👍 |
xabbuh commentedNov 17, 2015
👍 Status: Reviewed |
ewgRa commentedNov 17, 2015
Just a curious. What is a standard way to check OS in Symfony? At some places it is check DIRECTORY_SEPARATOR, in another places it is strpos(PHP_OS, "WIN") === 0. |
xabbuh commentedNov 17, 2015
@ewgRa We always check the value of the |
fabpot commentedNov 18, 2015
Thank you@kbond. |
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#16578).Discussion----------[Console] Fix bug in windows detection| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16577| License | MIT| Doc PR | n/aCommits-------c4068d9 Fix bug in windows detection