Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Asset] ability to set assets_version_strategy as service#16522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
ewgRa commentedNov 11, 2015
Test fail seems not related to this PR |
ContributorAuthor
ewgRa commentedDec 9, 2015
ping@fabpot, what do you think? I think it is great feature |
Conflicts:src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.phpsrc/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.phpsrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/assets.phpsrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/legacy_templating_assets.phpsrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/assets.xmlsrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/legacy_templating_assets.xmlsrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/assets.ymlsrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/legacy_templating_assets.ymlsrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
Member
fabpot commentedJan 25, 2016
As this is a new feature, it should be done on master instead.@ewgRa Can you rebase and submit a new PR? Thanks. |
ContributorAuthor
ewgRa commentedJan 25, 2016
Closed in favor#17532 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I working on#14832 I realize that all this problems and hidden magic can be avoided, if we will have ability to set asset version strategy as service.
This PR implementation of this idea.
Now it is possible to do something like this:
There is can be some conflicts with#16511, I will fix it, depends on which one PR will be merged first (or not merged) :)