Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.7][Asset] Ability to set empty version strategy in packages#16511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedNov 12, 2015
Won't the version be |
ewgRa commentedNov 12, 2015
There is a case, if version is omitted - then default strategy used. If we change it and if in xml omitted version considered as empty strategy (also as we need sync same logic for php, yml then) - we will have broken BC. There is also legacy code (framework templating configuration) that have different logic - omitted considered as empty. |
ewgRa commentedNov 12, 2015
There is no possible to set attribute in xml to null as far as I know :( |
XWB commentedNov 24, 2015
Ping@fabpot Any feedback on this? This bug was introduced with Symfony 2.7 and has not been resolved yet. |
ewgRa commentedDec 9, 2015
fabpot commentedJan 23, 2016
👍 @ewgRa Can you rebase to get rid of the 2 merge commit that prevents me from merging? Or even better, squash all commits. Thanks. |
ewgRa commentedJan 23, 2016
@fabpot done |
fabpot commentedJan 24, 2016
Thank you@ewgRa. |
…ages (ewgRa)This PR was merged into the 2.7 branch.Discussion----------[2.7][Asset] Ability to set empty version strategy in packages| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no, but not sure, as for me test was wrong| Deprecations? | no| Tests pass? | yes| Fixed tickets |#14832| License | MIT| Doc PR |Comment about '' thing. As you can see in xml test - we can't for attribute set null value. And for xml version '' empty string considered as null value, that affect all others formats and test is changed.Commits-------646fc9c Ability to set empty version strategy in packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR was merged into the 2.7 branch.Discussion----------[2.7][Asset] Add defaultNull to version configuration| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#14832,#16511| License | MIT| Doc PR |In#16511 PR was omitted defaultNull version for one case.Commits-------65adb72 add defaultNull to version
This PR was squashed before being merged into the 3.1-dev branch (closes#17532).Discussion----------[Asset] Version as service| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |While I working on#14832 I realize that all this problems and hidden magic can be avoided, if we will have ability to set asset version strategy as service.This PR implementation of this idea.Now it is possible to do something like this:```yamlframework: assets: version_strategy: assets.custom_version_strategy base_urls:http://cdn.example.com packages: foo: base_urls: ["https://example.com"] version_strategy: assets.custom_version_strategy```There is can be some conflicts with#16511 when it will be in masterCommits-------52d116b [Asset] Version as service
Comment about '' thing. As you can see in xml test - we can't for attribute set null value. And for xml version '' empty string considered as null value, that affect all others formats and test is changed.