Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpKernel] Keep 3.0 compat by not using ContainerAware#16466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedNov 4, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -24,9 +24,9 @@ | |||
| protected $container; | |||
| /** | |||
| * Sets the Container associated with this Controller. | |||
| * Sets the Container. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you lowercasecontainer please as it doesnt mean a class but a concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and these changes should be done in 2.7
Comments addressed |
👍 |
Thank you@nicolas-grekas. |
… (nicolas-grekas)This PR was merged into the 2.8 branch.Discussion----------[HttpKernel] Keep 3.0 compat by not using ContainerAware| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Commits-------31a0669 [HttpKernel] Keep 3.0 compat by not using ContainerAware