Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyAccess] Fix dynamic property accessing.#16462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedNov 4, 2015
please add a test covering this |
dunglas commentedNov 4, 2015
@stof some tests exist in 2.7 (it's how I've found I've broke things). I'll backport them ASAP but I've opened this PR right now because 2.3 is currently buggy. |
stof commentedNov 4, 2015
well, this PR is the one where backporting makes sense, as the backport is adding the test preventing this regression |
dunglas commentedNov 4, 2015
Test added |
dunglas commentedNov 4, 2015
AppVeyor failures look unrelated. |
nicolas-grekas commentedNov 5, 2015
👍 |
fabpot commentedNov 5, 2015
Thank you@dunglas. |
This PR was merged into the 2.3 branch.Discussion----------[PropertyAccess] Fix dynamic property accessing.| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aFix a bug regarding dynamic properties access introduced by#16294.Commits-------916f9e0 [PropertyAccess] Test access to dynamic properties352dfb9 [PropertyAccess] Fix dynamic property accessing.
Fix a bug regarding dynamic properties access introduced by#16294.