Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] GetSetNormalizer shouldn't set/get static methods#16454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromboekkooi:serializer-getset-static
Nov 5, 2015

Conversation

@boekkooi
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?maybe
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

This PR fixes setting static getters and setters when serializing.
This is strictly speaking a BC break but in my opinion a needed one because the current behavior is unexpected.

@dunglas
Copy link
Member

👍

It's why it would be nice to optimize performance of PropertyAccess component: it will allow to deprecate all normalizers exceptObjectNormalizer and ultimately ease maintenance.

@boekkooi
Copy link
ContributorAuthor

@dunglas I'm not sure I agree with that since PropertyNormalizer and GetSetNormalizer are more limited in scope then ProperyAccess and sometimes that's exactly what I want 😄
It would be nice to have some sort of ReflectionCache that could be provided to a Normalizer to avoid recreating instances.

@boekkooi
Copy link
ContributorAuthor

Status: Reviewed

@dunglas
Copy link
Member

I've introduced this cache system in the PropertyAccess component. It's why having a single normalizer relying on this component can enhance global performance and ease the maintenance.

@fabpot
Copy link
Member

Thank you@boekkooi.

@fabpotfabpot merged commitd8d4405 intosymfony:2.7Nov 5, 2015
fabpot added a commit that referenced this pull requestNov 5, 2015
…hods (boekkooi)This PR was merged into the 2.7 branch.Discussion----------[Serializer] GetSetNormalizer shouldn't set/get static methods| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | maybe| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -This PR fixes setting static getters and setters when serializing.This is strictly speaking a BC break but in my opinion a needed one because the current behavior is unexpected.Commits-------d8d4405 [Serializer] GetSetNormalizer shouldn't set/get static methods
@fabpotfabpot mentioned this pull requestNov 23, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@boekkooi@dunglas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp