NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Use mb_detect_encoding with $strict = true#16359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.3fromnicolas-grekas:mb-detect-fix

Oct 28, 2015

Merged

Use mb_detect_encoding with $strict = true#16359

fabpot merged 1 commit intosymfony:2.3fromnicolas-grekas:mb-detect-fix

Oct 28, 2015

Conversation

Copy link

Member

nicolas-grekas commentedOct 27, 2015

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Otherwise, UTF-8 can be returned for non-UTF8 strings...
See e.g.https://3v4l.org/oMMnX

Use mb_detect_encoding with $strict = true

e6c89f1

carsonbot added the Status: Needs Review label

Oct 27, 2015

Copy link

Member

fabpot commentedOct 28, 2015

Thank you@nicolas-grekas.

fabpot merged commite6c89f1 intosymfony:2.3

Oct 28, 2015

fabpot added a commit that referenced this pull request

Oct 28, 2015

bug#16359Use mb_detect_encoding with $strict = true (nicolas-grekas)

c7e772c

This PR was merged into the 2.3 branch.Discussion----------Use mb_detect_encoding with $strict = true| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Otherwise, UTF-8 can be returned for non-UTF8 strings...See e.g.https://3v4l.org/oMMnXCommits-------e6c89f1 Use mb_detect_encoding with $strict = true