Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Unescape parameters for all types of injection#16295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.3fromNicofuma:patch-1
Nov 19, 2015

Conversation

@Nicofuma
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

The parameters must be escaped when injected in the container.
But they are only unescaped when the container is dumped and when these parameters are used in the service constructor.
We need to unescape them every time their are injected (constructor, setter and property injection)

@stof
Copy link
Member

I don't understand what you are trying to fix here

@Nicofuma
Copy link
ContributorAuthor

Migth be clearer with a simple example:https://gist.github.com/Nicofuma/a7672bf0776efb2eaa5f
the output is:

"%%unescape_it%%""%unescape_it%"

while we are expecting:

"%unescape_it%""%unescape_it%"

@Nicofuma
Copy link
ContributorAuthor

Bump, this is a real issue for us as it throws an error to some of our users - because they have a % in their database password - each time they clear the cache.

@NicofumaNicofuma reopened thisNov 2, 2015
@Oyabun1
Copy link

this is a real issue for us as it throws an error to some of our users - because they have a % in their database password

I've had a few users of phpBB, experiencing the issue with the % character, try the changes in the commit and it resolved the problem for them.

@Nicofuma
Copy link
ContributorAuthor

Bump again

@stof could you give this PR another look please?

@Nicofuma
Copy link
ContributorAuthor

@stof@fabpot@Tobion anyone, could it be possible to have some feedbacks please?

@nicolas-grekas
Copy link
Member

👍
Status: reviewed

@fabpot
Copy link
Member

Thank you@Nicofuma.

@fabpotfabpot merged commit331a046 intosymfony:2.3Nov 19, 2015
fabpot added a commit that referenced this pull requestNov 19, 2015
… injection (Nicofuma)This PR was merged into the 2.3 branch.Discussion----------[DependencyInjection] Unescape parameters for all types of injection| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |The parameters must be escaped when injected in the container.But they are only unescaped when the container is dumped and when these parameters are used in the service constructor.We need to unescape them every time their are injected (constructor, setter and property injection)Commits-------331a046 [DependencyInjection] Unescape parameters for all types of injection
This was referencedNov 23, 2015
This was referencedNov 30, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Nicofuma@stof@Oyabun1@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp