Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Fix return type and anonymous classes dumping#16291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromnicolas-grekas:refl-type
Oct 20, 2015

Conversation

@nicolas-grekas
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

I missed thatgetReturnType returns aReflectionType instance that should be casted to string.

@stof
Copy link
Member

I suggest adding a test covering this for PHP 7+

@nicolas-grekas
Copy link
MemberAuthor

test added

@nicolas-grekasnicolas-grekas changed the title[VarDumper] Fix return type dumping[VarDumper] Fix return type and anonymous classes dumpingOct 19, 2015
@nicolas-grekas
Copy link
MemberAuthor

This PR now also fixes dumping PHP7 anonymous classes.

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitb42b03a intosymfony:2.7Oct 20, 2015
fabpot added a commit that referenced this pull requestOct 20, 2015
…(nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[VarDumper] Fix return type and anonymous classes dumping| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -I missed that `getReturnType` returns a `ReflectionType` instance that should be casted to string.Commits-------b42b03a [VarDumper] Fix return type and anonymous classes dumping
@nicolas-grekasnicolas-grekas deleted the refl-type branchOctober 20, 2015 08:05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what about an anonymous class not extending any parent class ? Is it valid ?

@fabpotfabpot mentioned this pull requestOct 27, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@stof@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp