Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WIP] [Form] Added support for Bootstrap 4 forms#16290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
EmanueleMinotto commentedOct 19, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16289 |
| License | MIT |
| Doc PR | - |
jvasseur commentedOct 19, 2015
You should probably create new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This doesn't do anything.
javiereguiluz commentedOct 19, 2015
@EmanueleMinotto maybe you should add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We don't usespaceless anymore in form themes. this has a perf impact as it performs a regex replacement on the rendered string. You should use whitespace control to remove the unnecessary spaces during the template compilation instead
EmanueleMinotto commentedOct 19, 2015
@jvasseur updated, thanks for all the feedbacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Glyphicon in not included anymore with bootstrap 4. Not sure what we should do here, maybe just removing it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catch! I agree that we should remove this.
fabpot commentedJan 25, 2016
@EmanueleMinotto what's the status of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Bootstrap4 has nohas-error style. It useshas-danger instead
FractalizeR commentedJan 25, 2016
@fabpot I think it's incomplete yet. I've glanced over the code (starting to work with Bootstrap 4 also) and found some places, derived from V3, that should be changed. |
EmanueleMinotto commentedJan 26, 2016
@fabpot I was followingtwbs/bootstrap#17021 waiting the v4 release (as@javiereguiluz told me above):
but I can also complete it without problems in any moment, could it be merged even if v4 isn't at the release? @FractalizeR thank you for your feedbacks, yes I started from the v3 template for the v4, but I'll fix the new templates following your feedbacks asap |
FractalizeR commentedJan 26, 2016
@EmanueleMinotto Thanks a lot. I will try to have another look over the weekend. I've started to use Bootstrap 4 for my home project and is also |
FractalizeR commentedJan 26, 2016
@fabpot Bootstrap 4 now removed icon set (Glyphicons) from main distribution. Should we consider ourselves completely empty of icons or should we use something like Font-Awesome? May be, by providing another alternative template, which will add icons? |
mahono commentedFeb 10, 2016
Why/where would icons be used in the form system? |
HeahDude commentedFeb 11, 2016
@mahono for alert signs in form errors |
fabpot commentedJun 9, 2016
Any news on this one? I'd love to have proper support for version 4 of Bootstrap |
javiereguiluz commentedJun 9, 2016
@fabpot we'll need to wait a bit because Bootstrap 4 is still releasing alpha versions and this could change before the final release (unlikely but possible). |
mvrhov commentedJun 9, 2016
Well then then the fixes can be added later when B4 gets released. If this works with latest alpha, then IMO it should get merged |
fabpot commentedJun 9, 2016
I agree, get this one finished, merged into master, then we have 6 months to tweak the code depending on what changes upstream. |
xabbuh commentedJun 11, 2016
When (roughly) can we expect the release of Bootstrap 4? |
mvrhov commentedJun 12, 2016
No ETA. Their usual moto was when it's done |
javiereguiluz commentedDec 22, 2016
Closing it because we have other PR for this:#19648 I know that this one is older ... but the other one seems to have gained more attention and it's fully reviewed. I'm sorry and thanks for understanding it. |