Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Unify URL generator reference type + make linking in php templates consistent with twig#16276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot added a commit that referenced this pull requestOct 18, 2015
This PR was squashed before being merged into the 2.3 branch (closes#16277).Discussion----------[Routing] use constants in tests| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Use constants in tests instead of hardcoded values in preparation for#16276Commits-------608c8d2 [Routing] use constants in tests
Member
fabpot commentedOct 18, 2015
👍 |
… line with twig templates
…s cumbersome to use constants in templates
22b777d to388fa43CompareContributorAuthor
Tobion commentedOct 18, 2015
Rebased |
Member
xabbuh commentedOct 19, 2015
👍 Status: Reviewed |
Member
fabpot commentedOct 19, 2015
Thank you@Tobion. |
fabpot added a commit that referenced this pull requestOct 19, 2015
…hp templates consistent with twig (Tobion)This PR was merged into the 2.8 branch.Discussion----------Unify URL generator reference type + make linking in php templates consistent with twig| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#14672| License | MIT| Doc PR | TODOPlease see ticket.Please merge#16277 first. I will then rebase this to make tests pass.Commits-------388fa43 [Templating] deprecate low-level RouterHelper::generate method as it's cumbersome to use constants in templates97d6828 [Templating] introduce path and url methods in php templates to be in line with twig templates912fc4d [Routing] deprecate the old url generator reference type values
This was referencedOct 20, 2015
Member
xabbuh commentedOct 20, 2015
seesymfony/symfony-docs#5813 andsymfony/symfony-docs#5814 for the documentation update |
craue added a commit to craue/CraueConfigBundle that referenced this pull requestOct 20, 2015
…on warnings while running testsseesymfony/symfony#16276
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestNov 5, 2015
This PR was merged into the 2.3 branch.Discussion----------use constants to choose generated URL type| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |symfony/symfony#16276Commits-------f00efff use constants to choose generated URL type
Merged
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestNov 30, 2015
This PR was merged into the 2.8 branch.Discussion----------Use path() and url() PHP templating helpers| Q | A| --- | ---| Doc fix? | no| New docs? | yes (symfony/symfony#16276)| Applies to | 2.8+| Fixed tickets |#5814Commits-------a4ad744 Use path() and url() PHP templating helpers
craue added a commit to craue/CraueFormFlowBundle that referenced this pull requestDec 1, 2015
…on warnings while running testsseesymfony/symfony#16276
craue added a commit to craue/CraueFormFlowBundle that referenced this pull requestDec 1, 2015
…on warnings while running testsseesymfony/symfony#16276
craue added a commit to craue/CraueFormFlowBundle that referenced this pull requestDec 1, 2015
…on warnings while running testsseesymfony/symfony#16276
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see ticket.
Please merge#16277 first. I will then rebase this to make tests pass.