Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarDumper] Fix wordwrap with Bootstrap#16183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.7fromogizanagi:var_dumper_html_fix_wrap
Oct 10, 2015
Merged

[VarDumper] Fix wordwrap with Bootstrap#16183

nicolas-grekas merged 1 commit intosymfony:2.7fromogizanagi:var_dumper_html_fix_wrap
Oct 10, 2015

Conversation

@ogizanagi
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

Without this rule, there can be issues in the profiler bar and css from bootstrap (https://github.com/twbs/bootstrap/blob/v3.3.5/less/code.less#L47)

screenshot 2015-10-09 a 18 09 28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

double word-break, see also#13487

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removingword-wrap: break-word will lead to#13487 issue.

Removingword-break: normal will lead to the issue targeted by this PR. This change only prevents issue if some css framework or whatever setword-break tobreak-all forpre tags.

@wouterj
Copy link
Member

👍 Also had this issue when using the Foundation CSS framework.

Status: Reviewed

@nicolas-grekas
Copy link
Member

Thank you@ogizanagi.

@nicolas-grekasnicolas-grekas merged commite448e1c intosymfony:2.7Oct 10, 2015
nicolas-grekas added a commit that referenced this pull requestOct 10, 2015
This PR was merged into the 2.7 branch.Discussion----------[VarDumper] Fix wordwrap with Bootstrap| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aWithout this rule, there can be issues in the profiler bar and css from bootstrap (https://github.com/twbs/bootstrap/blob/v3.3.5/less/code.less#L47)<img width="888" alt="screenshot 2015-10-09 a 18 09 28" src="https://cloud.githubusercontent.com/assets/2211145/10400156/645c77a6-6eb7-11e5-954b-f80c34b09f86.PNG">Commits-------e448e1c [VarDumper] Fix wordwrap with Bootstrap
@ogizanagiogizanagi deleted the var_dumper_html_fix_wrap branchOctober 10, 2015 18:47
@fabpotfabpot mentioned this pull requestOct 27, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ogizanagi@wouterj@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp