Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] sync translations and add a test for it#16146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedOct 6, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15955 |
| License | MIT |
| Doc PR |
ogizanagi commentedOct 6, 2015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When testing it from the Security component, I don't think there is the necessity to find thetranslation dir like this.
It'll always be into__DIR__.'/../Core/Resources/translations', right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
agreed
ba07797 to08333ecComparexabbuh commentedOct 6, 2015
I addressed the comments. |
stof commentedOct 6, 2015
👍 |
fabpot commentedOct 6, 2015
Thank you@xabbuh. |
This PR was merged into the 2.7 branch.Discussion----------[Security] sync translations and add a test for it| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15955| License | MIT| Doc PR |Commits-------08333ec [Security] sync translations and add a test for it