Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Process] Throw exception if tempnam returns false#16092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pierredup commentedOct 2, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15215 |
| License | MIT |
| Doc PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
prefix
The prefix of the generated temporary filename.
Note: Windows uses only the first three characters of prefix.
So the prefix would be the same for stdout and stderr on windows, which defeats the purpose. I propose to change the prefix to be different, e.g.out anderr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've changed this to useout_sf_proc anderr_sf_proc as the prefix
Tobion commentedOct 3, 2015
👍 |
Tobion commentedOct 3, 2015
For 2.3 the same would need to be applied inhttps://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Process/ProcessPipes.php#L52 |
pierredup commentedOct 4, 2015
…pierredup)This PR was merged into the 2.3 branch.Discussion----------Throw exception if tempnam returns false in ProcessPipes| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15215| License | MIT| Doc PR |Related to#16092Commits-------1425b8a Throw exception if tempnam returns false in ProcessPipes
Tobion commentedOct 4, 2015
Thank you@pierredup. |
…dup)This PR was merged into the 2.7 branch.Discussion----------[Process] Throw exception if tempnam returns false| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15215| License | MIT| Doc PR |Commits-------cc854e6 Throw exception if tempnam returns false