Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[CssSelector] removed the deprecated CssSelector class#16020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedSep 30, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| } | ||
| } | ||
| public function getCssToXPathWithoutPrefixTestData() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure all these tests where copied to the tests of the new class. It should be checked before removing them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
they are missing:https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/CssSelector/Tests/CssSelectorConverterTest.php
alsotestParseExceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
tests have been updated with#16052
Synchronizing the classes ensures that no tests are lost when the legacyAPI is removed insymfony#16020 for Symfony 3.0, thus mitigating the risk offuture regressions.
Synchronizing the classes ensures that no tests are lost when the legacyAPI is removed insymfony#16020 for Symfony 3.0, thus mitigating the risk offuture regressions.
…c API (xabbuh)This PR was merged into the 2.8 branch.Discussion----------[CssSelector] synchronize tests for static and non-static API| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Synchronizing the classes ensures that no tests are lost when the legacyAPI is removed in#16020 for Symfony 3.0, thus mitigating the risk offuture regressions.Commits-------2b29a40 synchronize tests for static and non-static API
… (fabpot)This PR was merged into the 3.0-dev branch.Discussion----------[CssSelector] removed the deprecated CssSelector class| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aCommits-------3ffa422 [CssSelector] removed the deprecated CssSelector class