Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

remove api tags from code#15979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tobion merged 1 commit intosymfony:2.3fromTobion:remove-api-tags
Sep 29, 2015
Merged

Conversation

@Tobion
Copy link
Contributor

QA
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#15977
LicenseMIT
Doc PRn/a

@stof
Copy link
Member

👍
status: reviewed

but I think the first step is actually to update the doc, to stop telling users about the distinction

@xabbuh
Copy link
Member

seesymfony/symfony-docs#5735 for the docs changes

@dunglas
Copy link
Member

👍

@fabpot
Copy link
Member

👍 I propose that you merge this PR and then merge it to 2.7/2.8/master, doing the needed addons; that would be much more efficient than doing a PR for each branch.

@TobionTobion merged commitf1c7c65 intosymfony:2.3Sep 29, 2015
Tobion added a commit that referenced this pull requestSep 29, 2015
This PR was merged into the 2.3 branch.Discussion----------remove api tags from code| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#15977| License       | MIT| Doc PR        | n/aCommits-------f1c7c65 remove api tags from code
@TobionTobion deleted the remove-api-tags branchSeptember 29, 2015 11:20
@Tobion
Copy link
ContributorAuthor

Merged in all branches. All api tags gone.

@fabpot
Copy link
Member

\o/

@King2500
Copy link
Contributor

What was the reason for this?

@stof
Copy link
Member

stof commentedOct 7, 2015

@King2500 the explanation is in the issue:#15977

short version: the@api tagging has not been maintained at all since 2.3, which means it is now meaningless

@King2500
Copy link
Contributor

I understand.

👍

weaverryan added a commit to symfony/symfony-docs that referenced this pull requestNov 5, 2015
… and API classes (xabbuh)This PR was merged into the 2.3 branch.Discussion----------[Contributing][Code] do not distinguish regular classes and API classes| Q             | A| ------------- | ---| Doc fix?      | no| New docs?     | kind of (symfony/symfony#15977,symfony/symfony#15979)| Applies to    | all| Fixed tickets |Commits-------9794d58 do not distinguish regular classes and API classes
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestDec 31, 2015
This PR was merged into the 2.3 branch.Discussion----------Remove references to API tagging| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.3| Fixed tickets | n/aRelated tosymfony/symfony#15977 andsymfony/symfony#15979.Commits-------d816c7f Remove references to API tagging
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Tobion@stof@xabbuh@dunglas@fabpot@King2500@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp