Imo this deserves a test to avoid regressions.

Status: Needs work

I agree with@xabbuh

@bouland Can you work on adding some unit tests?

I was a little lost, I didn't understand what was expected from me :
"Some changes should be done to comply with our standards."
I will add tests soon.

@bouland The pull request header (the table in the initial description was missing). I added it as you don't have the necessary permission to edit@fabpot's post.

@bouland Any news on this one?

Well i have not taken time to write the test.
Give me a week more.

Could you give me push access to the PR branch
fabpot:moved_domcrawler_20
thx

I can't. The best would be to close this PR and open a new one.

@bouland By the way, how did you end up with having aChoiceFormField object pointing to anoption element?

When i want to write a WebTestCase which submit a Form with a select with attribute disabled.

it calls$form->getPhpValues()

publicfunction Client::submit(Form$form, array$values =array()){$form->setValues($values);return$this->request($form->getMethod(),$form->getUri(),$form->getPhpValues(),$form->getPhpFiles());}

then the test$field->isDisabled() didn't work with ChoiceFormField of type "select"

publicfunction Form::getValues(){$values =array();foreach ($this->fields->all()as$name =>$field) {if ($field->isDisabled()) {continue;        }