Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] don't rely on internal sort implementation om test#15940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
xabbuh commentedSep 27, 2015
The builds were failing on HHVM and PHP7. Explanations can be found onhttps://bugs.php.net/bug.php?id=70289,php/php-src#999 andfacebook/hhvm#4649. |
Member
fabpot commentedSep 27, 2015
👍 |
PHP does not guarantuee how array elements with the same value will besorted when applying `asort()`. Since all namespaces used in the testproduce the same Levenshtein value, we should only check for presence ofthese namespaces instead of comparing the exact order.
4ae6b5f to3011fa0Compare2 tasks
Contributor
jakzal commentedSep 27, 2015
👍 |
MemberAuthor
xabbuh commentedSep 27, 2015
The Travis failures are not related to this PR. |
Member
fabpot commentedSep 27, 2015
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestSep 27, 2015
…test (xabbuh)This PR was merged into the 2.8 branch.Discussion----------[Console] don't rely on internal sort implementation om test| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#14894| License | MIT| Doc PR |PHP does not guarantuee how array elements with the same value will besorted when applying `asort()`. Since all namespaces used in the testproduce the same Levenshtein value, we should only check for presence ofthese namespaces instead of comparing the exact order.Commits-------3011fa0 don't rely on internal sort implementation in test
Member
GromNaN commentedSep 27, 2015
Thanks@xabbuh |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP does not guarantuee how array elements with the same value will be
sorted when applying
asort(). Since all namespaces used in the testproduce the same Levenshtein value, we should only check for presence of
these namespaces instead of comparing the exact order.