wouldn't this break cases where the command is allowing to get arguments interactively ininteract() ?

@stof afaics, this only binds, the validation is still done after interact. So I don't think it should cause trouble.

It also means listeners can add options/arguments without getting validation errors.

Failures related to#15940 and not this PR

@wouterj You could rebase as#15940 was merged (though we will still see some failures due to the security tests I think).

Please also add a test where the listener adds an option. And check if it can be used.

I was looking when validation actually happens as I sawsymfony/console#15.
It seems validation can happen both

• in$input->bind (when parsing), seehttps://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Console/Command/Command.php#L234
• in$input->validate(); which is called afterinteract, seehttps://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Console/Command/Command.php#L256

wouldn't this break cases where the command is allowing to get arguments interactively in interact() ?

So this case from@stof doesn't break because

• wrong arguments/options, e.g. too many would already error out when binding anyway
• missing arguments can still be added in interact as the number of arguments is only validated later

Please also add a test where the listener adds an option. And check if it can be used.

I think exactly that is still no possible with this solution. If you call a command with an option/argument that is only about to be added by a listener, it will throw an exception already when trying to parse the input via$input->bind(). So the listener won't have a chance to change the definition.

I think to solve the problem, we really need to refactor the validation.bind() should not validate but should parse everything indepently. And onlyvalidate checks if there are too many/missing/wrong arguments or options.

@Tobion yeah, or wrap things inside a try..catch loop as is done in other bind cases. (not doing validation inbind() is a BC break).

SoInput#validate() only validates if required arguments are passed.Input#bind() validates if passed options/arguments are valid. Added a try..catch loop around the binding before the event listener and added a test.

ping @symfony/deciders PR is now updated and ready to be merged imo

👍

Status: Reviewed

👍

Should we add a changelog entry so that people interested in changing the definition notice this is possible now?

Thank you@wouterj.