Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8#15929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
shouldn't it also be removed from implementations ? Or are the existing resources needing it ? |
Some tests rely on it and I don't know if users do. It only does not make sense at theinterface level because different implementations returned different types of values. |
When the implementations are kept, the documentation would need to be updated. They use Status: Needs Work |
Several resources used for tests also implement getResource for no reason anymore. |
this branch needs to be rebased too, as it conflicts with the current state |
Rebased, cleaned up and fixed. |
| @@ -44,7 +44,7 @@ public function __toString() | |||
| } | |||
| /** | |||
| *{@inheritdoc} | |||
| *@return string The file path to the resource | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
currently it can also returnfalse when realpath returns an error. So I propose to throw an exception in the constructor in this case which is ok in 3.0 i guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hm, maybe. But that has nothing to do with this PR, or? Shouldn't that be a differnt PR possibly with a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm fine with a different PR. But then the phpdoc is wrong at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed
Why does DirectoryResource not call |
I don't know why |
👍 Status: Reviewed |
Created#15946 for the remainder |
Thank you@mpdude. |
…which was deprecated in 2.8 (mpdude)This PR was squashed before being merged into the 3.0-dev branch (closes#15929).Discussion----------[3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Deprecated in#15719.Commits-------7cef180 [3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8
Deprecated in#15719.