Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Detect Mintty for color support on Windows#15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
stof wants to merge1 commit intosymfony:2.8fromstof:detect_mintty_colors

Conversation

@stof
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRsymfony/symfony-docs#5726

Mintty is now the default terminal in GitBash, and it supports ANSI colors without the need of ANSICON (it even supports 256 colors rather than the 16 colors supported by ANSICON).

I submitted it to 2.8 as it can be considered as a new feature. But it should not be hard to merge it in other branches if we decide to consider it as a bugfix (it just needs to be split because VarDumper does not exist in 2.3)

Mintty is now the default terminal in GitBash, and it supports ANSIcolors without the need of ANSICON (it even supports 256 colors ratherthan the 16 colors supported by ANSICON).
@stof
Copy link
MemberAuthor

Note that Mintty is used in Cygwin, so this would mean that Cygwin users get colored output for free now, without the need to use a second tool handling colors just to make the color support detected (or to pass--ansi explicitly all the time)

@fabpot
Copy link
Member

Sounds like a bug to me, should be merged in 2.3 instead.

@xabbuh
Copy link
Member

👍 (also to merge this into the2.3 branch)

@xabbuh
Copy link
Member

Status: Reviewed

@fabpot
Copy link
Member

Thank you@stof.

@stofstof deleted the detect_mintty_colors branchSeptember 27, 2015 13:09
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestOct 3, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#5726).Discussion----------Document the support of Mintty for colors| Q             | A| ------------- | ---| Doc fix?      | no| New docs?     | yessymfony/symfony#15915| Applies to    | 2.8+ (or 2.3+ depending on where it gets merged)| Fixed tickets | n/aCommits-------d8d4345 Document the support of Mintty for colors
This was referencedOct 27, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stof@fabpot@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp