Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[3.0][Security] Remove deprecated features#15899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
wouterj commentedSep 26, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
Member
stof commentedSep 26, 2015
You need to update the VoterFixture class to implement |
MemberAuthor
wouterj commentedSep 26, 2015
Member
fabpot commentedSep 30, 2015
@wouterj Can you finish this PR? |
2ea3de5 to6f9e897CompareMemberAuthor
wouterj commentedSep 30, 2015
@fabpot done. I've also removed |
Member
fabpot commentedSep 30, 2015
hmm, I've not checked, but I'm pretty sure they are some tests that need to be updated, no? |
MemberAuthor
wouterj commentedSep 30, 2015
Indeed, found some other tests and removed them as well |
Member
fabpot commentedSep 30, 2015
@wouterj Looks like |
MemberAuthor
wouterj commentedSep 30, 2015
Member
fabpot commentedSep 30, 2015
Thank you@wouterj. |
fabpot added a commit that referenced this pull requestSep 30, 2015
This PR was merged into the 3.0-dev branch.Discussion----------[3.0][Security] Remove deprecated features| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Commits-------c3c5989 Remove more tests6f9e897 Remove AbstractVoter#isGranted() method6b6de15 Removed supports{Attribute,Class}() methods
Koc added a commit to Koc/symfony that referenced this pull requestSep 30, 2015
Koc added a commit to Koc/symfony that referenced this pull requestSep 30, 2015
Koc added a commit to Koc/symfony that referenced this pull requestOct 1, 2015
Koc added a commit to Koc/symfony that referenced this pull requestOct 1, 2015
Koc added a commit to Koc/symfony that referenced this pull requestOct 1, 2015
Koc added a commit to Koc/symfony that referenced this pull requestOct 1, 2015
Koc added a commit to Koc/symfony that referenced this pull requestOct 1, 2015
Koc added a commit to Koc/symfony that referenced this pull requestOct 1, 2015
Koc added a commit to Koc/symfony that referenced this pull requestOct 1, 2015
fabpot added a commit that referenced this pull requestOct 2, 2015
#15899) (Koc)This PR was merged into the 3.0-dev branch.Discussion----------[3.0][Security] Remove deprecated features (follow up of#15899)| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15899| License | MIT| Doc PR | -- updated UPGRADE-3.0.md- removed unused `supportsClass` methods- changed visibility of `supportsAttribute` methods from public to private, removed `inheritdoc` annotation from them because there is no definition for this methods in parent interface- removed tests for `supportsClass` and `supportsAttribute` method- removed unused mock creationCommits-------437398d [3.0][Security] Remove deprecated features (follow up of#15899)
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.