Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Fix improper comments removal#15860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
skigun commentedSep 21, 2015
👍 |
Member
fabpot commentedOct 1, 2015
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestOct 1, 2015
This PR was merged into the 2.3 branch.Discussion----------[Yaml] Fix improper comments removal| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15857| License | MIT| Doc PR | -This tries tofix#15857 .Honestly, I don't have any idea of the regressions it might introduce. Tests are passing, so if this code had any reason to exist, tests covering it are certainly missing :/Any hint ?Commits-------0e24fc5 [Yaml] Fix improper comments removal inside strings
Member
fabpot commentedOct 2, 2015
reverted as it introduces regressions |
fabpot added a commit that referenced this pull requestOct 2, 2015
This PR was merged into the 2.3 branch.Discussion----------[Yaml] Add regression test for comments indents| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This is related to#16065,#15857 and#15860 (last one has been reverted due to this regression)Commits-------7b9d519 [Yaml] Add regression test for comments indents
fabpot added a commit that referenced this pull requestOct 2, 2015
* 2.3: [Yaml] Add regression test for comments indents Revert "bug#15860 [Yaml] Fix improper comments removal (ogizanagi)"
fabpot added a commit that referenced this pull requestOct 2, 2015
* 2.7: [Yaml] Add regression test for comments indents Revert "bug#15860 [Yaml] Fix improper comments removal (ogizanagi)"
fabpot added a commit that referenced this pull requestOct 2, 2015
* 2.8: [Yaml] Add regression test for comments indents Fix the DomCrawler tests Revert "bug#15860 [Yaml] Fix improper comments removal (ogizanagi)"
This was referencedOct 27, 2015
Closed
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries tofix#15857 .
Honestly, I don't have any idea of the regressions it might introduce. Tests are passing, so if this code had any reason to exist, tests covering it are certainly missing :/
Any hint ?