Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[travis] make the PHP version check for APC more robust#15616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
vicb wants to merge1 commit intosymfony:2.8fromvicb:0825-travis7

Conversation

@vicb
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

@nicolas-grekas
Copy link
Member

Does this fix anything?

@wouterj
Copy link
Member

@nicolas-grekas the current way means APC is configured for the 7.0 builds as well IIUC

@nicolas-grekas
Copy link
Member

@wouterj not really because of the firstif in the bash line

@vicb
Copy link
ContributorAuthor

PHP7 was what I had in mind when submitting this PR.

Releasing good SW is also about promoting good practices and IMO checking minor version number only is not one of them. However I could understand if you prefer closing this PR & feel free to do so.

@nicolas-grekas
Copy link
Member

Thanks@vicb see .travis.yml in#15575

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vicb@nicolas-grekas@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp