Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add appveyor.yml for C.I. on Windows#15575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 2 commits intosymfony:2.3fromnicolas-grekas:appveyor
Aug 26, 2015

Conversation

@nicolas-grekas
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?YES, both on Travis (Linux) and on Appveyor (Windows)!
Fixed tickets#13934,#15049,#14259,#15045,#15444
LicenseMIT
Doc PRsymfony/symfony-docs#5654
  • testing two matrix lines:
    • one without mbtring nor fileinfo nor intl
    • one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component
  • bug fixes thanks to these harder testing conditions
  • some display bug on appveyor,reported here.

@stof
Copy link
Member

should we also try compiling the debug extension on Windows ? Or should we wait until we decide whether we move it to a separate repo ?
In any case, it is irrelevant for 2.3 as it does not have the C extension

appveyor.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what about using native ways to download files instead ?http://www.appveyor.com/docs/how-to/download-file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

btw, this is already done for the php.zip file.

and downloading phpunit should also be part of the installation rather than the tests

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Because I'd prefer having commands read/writables by us. And also because cakephp does this way :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

but the current comment could have issues. seehttps://github.com/symfony/symfony-installer/issues/137

@nicolas-grekas
Copy link
MemberAuthor

That would be great to have the debug ext compiled also, but let's first make this one work.

@fabpot
Copy link
Member

Account has been created now. Try to push here to trigger a new build as I don't seem to have any way to do that from the interface.

@nicolas-grekas
Copy link
MemberAuthor

@fabpot thanks, did you setup the webhook?
Here is a helper screenshot for PR support:

11

@nicolas-grekasnicolas-grekasforce-pushed theappveyor branch 3 times, most recently from2197a23 to32932f5CompareAugust 18, 2015 16:32
appveyor.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

your composer bat file does not work

@nicolas-grekasnicolas-grekasforce-pushed theappveyor branch 3 times, most recently from7b474b0 to646b0dbCompareAugust 18, 2015 17:03
@nicolas-grekas
Copy link
MemberAuthor

The build is now working! But phpunit crashes before going to the end of the test suite :(
Any Windows expert here?

appveyor.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the current stable version of PHPUnit is 4.8, not 4.7

@stof
Copy link
Member

@nicolas-grekas can you try running the testsuite in smaller chunks (component by component) to see whether it helps ? We are not running the full testsuite in 1 go on Travis (even though the main goal was to parallelize runs to be faster)

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedAug 18, 2015 via email

If you give me the command to do so, yes :)

@nicolas-grekas
Copy link
MemberAuthor

Any PowerShell scripter here? We would need a ps script to run phpunit tests in parallel, the same as we do on unixes withfind src/Symfony -mindepth 3 -type f -name phpunit.xml.dist -printf '%h\n' | parallel --gnu --keep-order 'echo -e "\\nRunning {} tests"; php --exclude-group tty,benchmark,intl-data {} || (echo "KO {}" && $(exit 1));'

Invole-Parallel could maybe help, but I must admit I'm a total noob here.

@nicolas-grekas
Copy link
MemberAuthor

An other idea could be to run bash from cygwin, it's maybe even already somewhere on the vm.

@wouterj
Copy link
Member

@nicolas-grekas I have both powershell and cygwin on my PC, what do you want me to do/try?

@nicolas-grekasnicolas-grekasforce-pushed theappveyor branch 3 times, most recently fromf653ba4 toccc91e9CompareAugust 18, 2015 21:45
@nicolas-grekas
Copy link
MemberAuthor

Status: needs review
Except for a transient test on the Process component, tests are green.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

pecl intl 3.0 backports php5.5 behavior to 5.3/5.4

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some invalid timezones are accepted by DateTimeZone since 5.5.10, but rejected by IntlDateFormatter.

@nicolas-grekas
Copy link
MemberAuthor

ping @symfony/deciders , especially@webmozart

@fabpot
Copy link
Member

Not mergeable yet as there is still a failing test on Windows.

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitea5d656 intosymfony:2.3Aug 26, 2015
fabpot added a commit that referenced this pull requestAug 26, 2015
This PR was merged into the 2.3 branch.Discussion----------Add appveyor.yml for C.I. on Windows| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | YES, both on Travis (Linux) and on Appveyor (Windows)!| Fixed tickets |#13934,#15049,#14259,#15045,#15444| License       | MIT| Doc PR        |symfony/symfony-docs#5654- testing two matrix lines:  - one without mbtring nor fileinfo nor intl  - one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component- bug fixes thanks to these harder testing conditions- some display bug on appveyor, [reported here](http://help.appveyor.com/discussions/suggestions/197-support-ansi-color-codes).Commits-------ea5d656 Windows and Intl fixes8bbd8d9 Add appveyor.yml for C.I. on Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas why testing against PHP 5.4 which is nearly EOL rather than against PHP 5.6 ?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

because I couldn't find a .dll for intl + icu 51.2 for 5.5 (vc9-nts-x86)

@nicolas-grekasnicolas-grekas deleted the appveyor branchAugust 26, 2015 11:50
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestSep 8, 2015
This PR was merged into the 2.3 branch.Discussion----------Doc about new way of running tests| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | yes| Applies to    | all| Fixed tickets | -Related tosymfony/symfony#15575Commits-------dc754c8 Doc about new way of running tests
This was referencedOct 28, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nicolas-grekas@stof@fabpot@wouterj@ioleo@andrerom@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp