Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add appveyor.yml for C.I. on Windows#15575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedAug 18, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | YES, both on Travis (Linux) and on Appveyor (Windows)! |
| Fixed tickets | #13934,#15049,#14259,#15045,#15444 |
| License | MIT |
| Doc PR | symfony/symfony-docs#5654 |
- testing two matrix lines:
- one without mbtring nor fileinfo nor intl
- one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component
- bug fixes thanks to these harder testing conditions
- some display bug on appveyor,reported here.
stof commentedAug 18, 2015
should we also try compiling the debug extension on Windows ? Or should we wait until we decide whether we move it to a separate repo ? |
appveyor.yml Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about using native ways to download files instead ?http://www.appveyor.com/docs/how-to/download-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
btw, this is already done for the php.zip file.
and downloading phpunit should also be part of the installation rather than the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because I'd prefer having commands read/writables by us. And also because cakephp does this way :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
but the current comment could have issues. seehttps://github.com/symfony/symfony-installer/issues/137
nicolas-grekas commentedAug 18, 2015
That would be great to have the debug ext compiled also, but let's first make this one work. |
fabpot commentedAug 18, 2015
Account has been created now. Try to push here to trigger a new build as I don't seem to have any way to do that from the interface. |
nicolas-grekas commentedAug 18, 2015
@fabpot thanks, did you setup the webhook? |
2197a23 to32932f5Compareappveyor.yml Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
your composer bat file does not work
7b474b0 to646b0dbComparenicolas-grekas commentedAug 18, 2015
The build is now working! But phpunit crashes before going to the end of the test suite :( |
appveyor.yml Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the current stable version of PHPUnit is 4.8, not 4.7
stof commentedAug 18, 2015
@nicolas-grekas can you try running the testsuite in smaller chunks (component by component) to see whether it helps ? We are not running the full testsuite in 1 go on Travis (even though the main goal was to parallelize runs to be faster) |
nicolas-grekas commentedAug 18, 2015 via email
If you give me the command to do so, yes :) |
nicolas-grekas commentedAug 18, 2015
Any PowerShell scripter here? We would need a ps script to run phpunit tests in parallel, the same as we do on unixes with Invole-Parallel could maybe help, but I must admit I'm a total noob here. |
nicolas-grekas commentedAug 18, 2015
An other idea could be to run bash from cygwin, it's maybe even already somewhere on the vm. |
wouterj commentedAug 18, 2015
@nicolas-grekas I have both powershell and cygwin on my PC, what do you want me to do/try? |
f653ba4 toccc91e9Comparenicolas-grekas commentedAug 25, 2015
Status: needs review |
e044e77 toaa357f8CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
pecl intl 3.0 backports php5.5 behavior to 5.3/5.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some invalid timezones are accepted by DateTimeZone since 5.5.10, but rejected by IntlDateFormatter.
nicolas-grekas commentedAug 25, 2015
ping @symfony/deciders , especially@webmozart |
f01bff8 to05efbe1Comparefabpot commentedAug 26, 2015
Not mergeable yet as there is still a failing test on Windows. |
fabpot commentedAug 26, 2015
Thank you@nicolas-grekas. |
This PR was merged into the 2.3 branch.Discussion----------Add appveyor.yml for C.I. on Windows| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | YES, both on Travis (Linux) and on Appveyor (Windows)!| Fixed tickets |#13934,#15049,#14259,#15045,#15444| License | MIT| Doc PR |symfony/symfony-docs#5654- testing two matrix lines: - one without mbtring nor fileinfo nor intl - one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component- bug fixes thanks to these harder testing conditions- some display bug on appveyor, [reported here](http://help.appveyor.com/discussions/suggestions/197-support-ansi-color-codes).Commits-------ea5d656 Windows and Intl fixes8bbd8d9 Add appveyor.yml for C.I. on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas why testing against PHP 5.4 which is nearly EOL rather than against PHP 5.6 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because I couldn't find a .dll for intl + icu 51.2 for 5.5 (vc9-nts-x86)
This PR was merged into the 2.3 branch.Discussion----------Doc about new way of running tests| Q | A| ------------- | ---| Doc fix? | yes| New docs? | yes| Applies to | all| Fixed tickets | -Related tosymfony/symfony#15575Commits-------dc754c8 Doc about new way of running tests
