NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Translator][fallback catalogues] fixed circular reference.#15527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.3fromaitboudad:translator_circular_reference

Sep 2, 2015

Merged

[Translator][fallback catalogues] fixed circular reference.#15527

fabpot merged 1 commit intosymfony:2.3fromaitboudad:translator_circular_reference

Sep 2, 2015

Conversation

Copy link

Contributor

aitboudad commentedAug 12, 2015

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	~
Tests pass?	yes
License	MIT

aitboudad added Bug Translation labels

Aug 12, 2015

carsonbot added the Status: Needs Review label

Aug 12, 2015

aitboudad mentioned this pull request

Aug 12, 2015

[Translator][warmup][fallback locales] fixed missing cache file generation.#15516

Merged

aitboudad force-pushed thetranslator_circular_reference branch from559baab toea9c63dCompare

August 12, 2015 16:10

aitboudad mentioned this pull request

Aug 14, 2015

Circular reference detected when adding a fallback catalogue "nl"#15522

Closed

Copy link

kimausloos commentedAug 14, 2015

This fixes issue#15522

aitboudad changed the title~~[Translator][fallback catalogues] fixed circular reference.~~[WIP][Translator][fallback catalogues] fixed circular reference.

Aug 17, 2015

[Translator][fallback catalogues] fixed circular reference.

79e29c1

aitboudad force-pushed thetranslator_circular_reference branch fromea9c63d to79e29c1Compare

September 2, 2015 10:03

aitboudad changed the title~~[WIP][Translator][fallback catalogues] fixed circular reference.~~[Translator][fallback catalogues] fixed circular reference.

Sep 2, 2015

Copy link

ContributorAuthor

aitboudad commentedSep 2, 2015

@symfony/deciders can someone review please :)

Copy link

Member

stof commentedSep 2, 2015

what happens if you definedarray('fr', 'en') as fallback locales and you load either fr or en as fallback locales. what would be the fallbacks for each of them ?

Copy link

ContributorAuthor

aitboudad commentedSep 2, 2015

@stof
fr -> en as fallback
en -> fr as fallback

Copy link

Member

well, this looks weird to me though, as the fr fallback of en will be different from the fr catalogue used anywhere else. But it is indeed one of the possible implementations. the other one could be to consider thaten does not fallback to anything here, as it is itself the last fallback locale.

Anyway it is a different topic (and a behavior change, so not for 2.3), so it should be discussed separately.

👍 for this
status: reviewed

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Sep 2, 2015

Copy link

Member

fabpot commentedSep 2, 2015

Thank you@aitboudad.

fabpot merged commit79e29c1 intosymfony:2.3

Sep 2, 2015

fabpot added a commit that referenced this pull request

Sep 2, 2015

bug#15527[Translator][fallback catalogues] fixed circular reference…

59ade35

…. (aitboudad)This PR was merged into the 2.3 branch.Discussion----------[Translator][fallback catalogues] fixed circular reference.| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Fixed tickets  | ~| Tests pass?   | yes| License       | MITCommits-------79e29c1 [Translator][fallback catalogues] fixed circular reference.

aitboudad deleted the translator_circular_reference branch

September 2, 2015 15:10

c960657 mentioned this pull request

Jan 28, 2016

[Translation] Add resources from fallback locale to parent catalogue#17596

Merged

Copy link

Contributor

c960657 commentedJan 28, 2016

I believe this caused a regression:#17596

fabpot added a commit that referenced this pull request

Jan 31, 2016

bug#17596[Translation] Add resources from fallback locale to parent…

27de563

… catalogue (c960657)This PR was merged into the 2.3 branch.Discussion----------[Translation] Add resources from fallback locale to parent catalogue| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -The resources representing a locale includes those of the fallback locale. However, `getCatalogue()->getResources()` only returns the resources belonging specifically to the selected locale.Example: The locale `en_GB` falls back to `en`. I use the locale `en_GB`. During development, when I modify the `en_GB` translation file, the changes appear instantly when reloading the page. If I modify the `en` translation file, I need to manually clear the cache in order for the new translation to appear.I believe this is a regression that was introduced in#15527.This patch is for the 2.3 branch. For 2.6 and later, the test can be updated to use the getCatalogue() method instead of using ReflectionProperty.Commits-------f7f82fa [Translation] Add resources from fallback locale