Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Improve newline handling in folded scalar blocks#15482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
teohhanhui commentedAug 7, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15477 |
| License | MIT |
| Doc PR | N/A |
javiereguiluz commentedAug 7, 2015
@teohhanhui I'm glad that after the discussion in#15477 issue you have created the pull request according to the format required by Symfony. We have a bot called "fabbot" which reviews the submitted pull requests for basic errors. Although the bot is reporting an error for this pull request, we can safely ignore it because it's related to some feature needed for the unit tests. So everything is ready to be reviewed by our team and ultimately merge it in Symfony. Let's wait for the revision. Thanks! |
teohhanhui commentedAug 7, 2015
@javiereguiluz No worries. Actually, I'm not new to Symfony and the contributing process. |
3fc7774 to5b9a602Comparestof commentedAug 7, 2015
@javiereguiluz we should make fabbot ignore the Yaml test fixtures to avoid reporting this issue here (or we should refactor the way we pass Yaml test fixtures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
renaming a constant is a BC break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What do you suggest then? Can I recreate it like this?
constFOLDED_SCALAR_PATTERN =self::BLOCK_SCALAR_PATTERN;
5b9a602 to3070586Compare3070586 to73366d5Compareteohhanhui commentedAug 11, 2015
PHP7 build is failing on Travis... Does it have anything to do with my code? |
jakzal commentedAug 11, 2015
Tests for theHttpFoundation fail, so it doesn't seem to be an issue related to your PR@teohhanhui. |
teohhanhui commentedAug 14, 2015
Are we good on this? |
teohhanhui commentedAug 21, 2015
ping@stof |
teohhanhui commentedSep 2, 2015
Any changes required before this will get merged? |
stof commentedSep 2, 2015
👍 |
1 similar comment
jakzal commentedSep 29, 2015
👍 |
fabpot commentedSep 30, 2015
Thank you@teohhanhui. |
…eohhanhui)This PR was merged into the 2.3 branch.Discussion----------[Yaml] Improve newline handling in folded scalar blocks| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15477| License | MIT| Doc PR | N/ACommits-------73366d5 [Yaml] Improve newline handling in folded scalar blocks