Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[SecurityBundle] Remove deprecated code#15430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[SecurityBundle] Remove deprecated code#15430
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dosten commentedAug 2, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
| ->beforeNormalization() | ||
| ->ifString()->then(function ($v) { return array($v); }) | ||
| ->end() | ||
| ->prototype('scalar')->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This formatting change altering the indentation should be avoided, to make it easier to merge branches together (otherwise we would have to resolve conflicts all the time during the 2.x lifetime when changes are done on this code and propagated to 3.x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@stof fixed
@stof sorry, my bad. fixed. |
👍 |
2 similar comments
👍 |
👍 |
Great! Status: Reviewed |
Thank you@dosten. |
This PR was merged into the 3.0-dev branch.Discussion----------[SecurityBundle] Remove deprecated code| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| License | MITCommits-------7c4f921 Remove deprecated code