Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added {{ value }} message placeholder to UniqueEntityValidator#15279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jperovic wants to merge1 commit intosymfony:2.8fromjperovic:ticket_15268
Closed

Added {{ value }} message placeholder to UniqueEntityValidator#15279

jperovic wants to merge1 commit intosymfony:2.8fromjperovic:ticket_15268

Conversation

@jperovic
Copy link
Contributor

QA
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#15268
LicenseMIT
Doc PR-

Apologize if I missed something. This is my first contribution to a large scale project.

@jperovic
Copy link
ContributorAuthor

Just wanted to ask quick question here, to which I didn't find any answer in CONTRIBUTING document.

When I run "phpunit" command, it works until it gets stuck withQuestionHelperTest::testAskChoice test. I did a little bit of research and it seems that it gets stuck due tointeractive argument being set totrue inInputStream instance. After that, code hits this infinitewhile loop ($attempts isNULL):

# Symfony\Component\Console\Helper\QuestionHelper::validateAttempts()while (null ===$attempts ||$attempts--) {if (null !==$error) {$this->writeError($output,$error);            }try {returncall_user_func($question->getValidator(),$interviewer());            }catch (\Exception$error) {            }        }

Is this known limitation? I haveCentos 6.5 andPHP 5.6...

@jakzal
Copy link
Contributor

@jperovic that's a bug. I'm looking into this.

@jperovic
Copy link
ContributorAuthor

@jakzal Cool, thanks :)

@Minishlink
Copy link

Hello, thanks for this ! 👍

Just a quick note: UniqueEntityValidator can have several fields. As such, one should be able to refer to all these fields in the validation message eg. "The combination of {{ field1 }} and {{ field2 }} should be unique.".

Also, see#15201. You both address the same issue.

@fabpot
Copy link
Member

@jakzal Are you still looking at this bug?

@jakzal
Copy link
Contributor

@fabpot I fixed it in#15280. Looks like I forgot to update this ticket (which is actually not related to the issue with tests).

@fabpot
Copy link
Member

Thank you@jperovic.

@jperovicjperovic deleted the ticket_15268 branchJanuary 28, 2016 07:05
@fabpotfabpot mentioned this pull requestMay 13, 2016
fabpot added a commit that referenced this pull requestNov 6, 2016
This PR was merged into the 3.1 branch.Discussion----------Properly format value in UniqueEntityValidator| Q | A || --- | --- || Branch? | 3.1 || Bug fix? | yes || New feature? | no || BC breaks? | no || Deprecations? | no || Tests pass? | yes || Fixed tickets | / || License | MIT |This PR fixes a small issue introduced in#15279. Having an array in a field considered for a unique check causes an array to string conversion error in the translator. This can be avoided by formatting the value parameter with `formatValue`.Commits-------9043a55 Properly format value in UniqueEntityValidator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jperovic@jakzal@Minishlink@fabpot@aitboudad

[8]ページ先頭

©2009-2025 Movatter.jp