Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Added ParameterBagInterface::remove#15219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromlyrixx:param-bag-remove
Jul 14, 2015

Conversation

lyrixx
Copy link
Member

QA
Bug fix?kinda
New feature?no
BC breaks?only between 2.X and 3.X, this PR target 3.X
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

I created this PR because the method is implemented inParameterBag but is not declared in the interface.

@linaori
Copy link
Contributor

Is it possible to add aremoveParameter method in theContainerBuilder or is that out of this scope?

@lyrixx
Copy link
MemberAuthor

Is it possible to add a removeParameter method in the ContainerBuilder or is that out of this scope?

I guess it's out of this scope

@mickaelandrieu
Copy link
Contributor

@lyrixx what is the gain ? This sound like a free BC for no gain.

@lyrixx
Copy link
MemberAuthor

@mickaelandrieu Now, we can be sure the method exist before calling it.

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commitc13a4ff intosymfony:masterJul 14, 2015
fabpot added a commit that referenced this pull requestJul 14, 2015
…ove (lyrixx)This PR was merged into the 3.0-dev branch.Discussion----------[DependencyInjection] Added ParameterBagInterface::remove| Q             | A| ------------- | ---| Bug fix?      | kinda| New feature?  | no| BC breaks?    | only between 2.X and 3.X, this PR target 3.X| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -I created this PR because the method is implemented in `ParameterBag` but is not declared in the interface.Commits-------c13a4ff [DependencyInjection] Added ParameterBagInterface::remove
@lyrixxlyrixx deleted the param-bag-remove branchJuly 14, 2015 15:59
@xabbuh
Copy link
Member

This should be documented in the upgrade file.

xabbuh added a commit to xabbuh/symfony that referenced this pull requestJul 15, 2015
This commit documents the addition of the `remove()` method to the`ParameterBagInterface` which was done insymfony#15219.
@xabbuh
Copy link
Member

see#15286

@mickaelandrieu
Copy link
Contributor

@xabbuh 👍 thank you.

fabpot added a commit that referenced this pull requestJul 15, 2015
…cs (xabbuh)This PR was merged into the 3.0-dev branch.Discussion----------[DependencyInjection] mention added method in upgrade docs| Q             | A| ------------- | ---| Fixed tickets |#15219| License       | MITThis commit documents the addition of the `remove()` method to the`ParameterBagInterface` which was done in#15219.Commits-------706d1a8 mention added method in upgrade docs
@fabpotfabpot mentioned this pull requestNov 16, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@lyrixx@linaori@mickaelandrieu@fabpot@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp