Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] fix IntlDataFormatter default pattern#15045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
ewgRa commentedJun 19, 2015
Seems ICU changes. I have 52.1 and there is comma as delimiter, maybe then add ICU version check to tests that fail with such ICU? |
fabpot added a commit that referenced this pull requestAug 26, 2015
This PR was merged into the 2.3 branch.Discussion----------Add appveyor.yml for C.I. on Windows| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | YES, both on Travis (Linux) and on Appveyor (Windows)!| Fixed tickets |#13934,#15049,#14259,#15045,#15444| License | MIT| Doc PR |symfony/symfony-docs#5654- testing two matrix lines: - one without mbtring nor fileinfo nor intl - one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component- bug fixes thanks to these harder testing conditions- some display bug on appveyor, [reported here](http://help.appveyor.com/discussions/suggestions/197-support-ansi-color-codes).Commits-------ea5d656 Windows and Intl fixes8bbd8d9 Add appveyor.yml for C.I. on Windows
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without installed Intl extension tests failed, because seems IntlDataFormatter replacement have bug.
In this PR proof-test for this case and fix.
Not sure about "BC breaks"