Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy#15031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJun 18, 2015
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | - |
License | MIT |
Doc PR | symfony/symfony-docs#5413 |
This may be an issue for deprecations triggered in other libraries than Symfony though, if they don't use the new silencing pattern |
Yes and no: if the deprecations where in place before the bridge was released, then these libs already have a way to make their users handle them. If the deprecations where added by taking inspiration from Symfony, then this is a recent move and I'd advocate we need to push them one step forward. |
Well, pushing to the new way is indeed a good idea. 👍 You should also updatehttp://symfony.com/doc/current/contributing/code/conventions.html#deprecations with the new convention btw |
Doc PR issymfony/symfony-docs#5413 |
Thank you@nicolas-grekas. |
… according to new policy (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#5413Commits-------9eea9eb [PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy