Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy#15031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromnicolas-grekas:deprec-strict
Jun 19, 2015

Conversation

nicolas-grekas
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PRsymfony/symfony-docs#5413

@stof
Copy link
Member

This may be an issue for deprecations triggered in other libraries than Symfony though, if they don't use the new silencing pattern

@nicolas-grekas
Copy link
MemberAuthor

Yes and no: if the deprecations where in place before the bridge was released, then these libs already have a way to make their users handle them. If the deprecations where added by taking inspiration from Symfony, then this is a recent move and I'd advocate we need to push them one step forward.
It took us several months to create the current deprecation policy and I now really like it. This bridge should help spread the word :)

@stof
Copy link
Member

Well, pushing to the new way is indeed a good idea. 👍

You should also updatehttp://symfony.com/doc/current/contributing/code/conventions.html#deprecations with the new convention btw

@nicolas-grekas
Copy link
MemberAuthor

Doc PR issymfony/symfony-docs#5413

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit9eea9eb intosymfony:2.7Jun 19, 2015
fabpot added a commit that referenced this pull requestJun 19, 2015
… according to new policy (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        |symfony/symfony-docs#5413Commits-------9eea9eb [PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy
@nicolas-grekasnicolas-grekas deleted the deprec-strict branchJuly 1, 2015 15:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@nicolas-grekas@stof@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp