Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Bugfix webprofiler#15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When the session attributes don't exist, $data->sessionAttributes->getRawValue() cannot be called as not being defined.So check the session attributes before calling getRawValue()
dawehner pushed a commit to dawehner/symfony that referenced this pull requestJul 1, 2013
dawehner pushed a commit to dawehner/symfony that referenced this pull requestJul 1, 2013
dawehner pushed a commit to dawehner/symfony that referenced this pull requestJul 1, 2013
dawehner pushed a commit to dawehner/symfony that referenced this pull requestJul 1, 2013
dawehner pushed a commit to dawehner/symfony that referenced this pull requestJul 1, 2013
Fixedsymfony#15 When using the chain router in a compiler pass, cache warmup fails
SofHad pushed a commit to SofHad/symfony that referenced this pull requestOct 12, 2015
…& end and removed doubles dashes (Sebastian Blum)This PR was merged into the master branch.Discussion----------Optimized slugger: trimming dash at the beginning & end and removed doubles dashesHello,I found the symfony-demo repository and the idea behind is great.also in the symfony best practices, the slugger has 2 problems in my opinion.* several dashes like lorem--ipsum* dashes at the begin or end like -lorem-ipsum-here is my litte pull request.sebastianCommits-------5c82409 Optimized slugger: trimming dash at the beginning & end and removed double dashes
fabpot added a commit that referenced this pull requestMar 22, 2017
…ject (eko)This PR was merged into the 2.7 branch.Discussion----------[Security] Fixed roles serialization on token from user object| Q | A || --- | --- || Branch? | 2.7 || Bug fix? | yes || New feature? | no || BC breaks? | no || Deprecations? | no || Tests pass? | yes || Fixed tickets |#14274 || License | MIT || Doc PR | - |This PR fixes the serialization of tokens when using `Role` objects provided from the user. Indeed, there were actually a reference issue that can causes fatal errors like the following one:```FatalErrorException in RoleHierarchy.php line 43:Error: Call to a member function getRole() on string```Here is a small code example to reproduce and its output:``` php$user = new Symfony\Component\Security\Core\User\User('name', 'password', [ new Symfony\Component\Security\Core\Role\Role('name')]);$token = new Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken($user, 'password', 'providerKey', $user->getRoles());$serialized = serialize($token);$unserialized = unserialize($serialized);var_dump($unserialized->getRoles());```Before:```array(1) { [0]=> bool(true) }```After:```array(1) { [0]=> object(Symfony\Component\Security\Core\Role\Role)#15 (1) {["role":"Symfony\Component\Security\Core\Role\Role":private]=> string(4) "name" } }```Thank youCommits-------dfa7f50 [Security] Fixed roles serialization on token from user object
jderusse pushed a commit to jderusse/symfony that referenced this pull requestMar 30, 2020
chalasr pushed a commit to chalasr/symfony that referenced this pull requestSep 24, 2020
* Selenium manager* Selenium manager create method* fix cs* simple test* fix selenium manager test* fix travis ci test, fix cs* fix cs* fix cs, refactor constructor* fix constructor* fix test
OskarStark pushed a commit to PGLongo/symfony that referenced this pull requestDec 22, 2020
# Das ist die erste Commit-Beschreibung:[Notifier] add support for gatewayapi-notifier# Die Commit-Beschreibungsymfony#2 wird ausgelassen:# Make GatewayAPITransportFactory final# Die Commit-Beschreibungsymfony#3 wird ausgelassen:# Fix typo in gatewaypi# Die Commit-Beschreibungsymfony#4 wird ausgelassen:# Fix typo# Die Commit-Beschreibungsymfony#5 wird ausgelassen:# Update README.md# Die Commit-Beschreibungsymfony#6 wird ausgelassen:# Rename GatewayAPI -> GatewayApi# Die Commit-Beschreibungsymfony#7 wird ausgelassen:# Add GatewayApiTransportFactory tests# Die Commit-Beschreibungsymfony#8 wird ausgelassen:# Add GatewayApiTransportTest testSend# Die Commit-Beschreibungsymfony#9 wird ausgelassen:# Add GatewayApiTransportTest testSupportsSmsMessage# Die Commit-Beschreibungsymfony#10 wird ausgelassen:# Add GatewayApiTransportTest testNotSupportsChatMessage# Die Commit-Beschreibungsymfony#11 wird ausgelassen:# Lint code# Die Commit-Beschreibungsymfony#12 wird ausgelassen:# Fix name and email in composer.json## Co-authored-by: Tobias Nyholm <tobias.nyholm@gmail.com># Die Commit-Beschreibungsymfony#13 wird ausgelassen:# Remove extra from composer.json# Die Commit-Beschreibungsymfony#14 wird ausgelassen:# Update version tag in GatewayApiTransport# Die Commit-Beschreibungsymfony#15 wird ausgelassen:# Add /.gitattributes export-ignore in .gitattributes# Die Commit-Beschreibungsymfony#16 wird ausgelassen:# Update UnsupportedSchemeException# Die Commit-Beschreibungsymfony#17 wird ausgelassen:# Add required space in phpdoc# Die Commit-Beschreibungsymfony#18 wird ausgelassen:# Update GatewayApiTransportFactory.php## Update version tag in GatewayApiTransportFactory# Die Commit-Beschreibungsymfony#19 wird ausgelassen:# [Notifier] add support for gatewayapi-notifier# Die Commit-Beschreibungsymfony#20 wird ausgelassen:# Make GatewayAPITransportFactory final# Die Commit-Beschreibungsymfony#21 wird ausgelassen:# Make GatewayAPITransportFactory final# Die Commit-Beschreibungsymfony#22 wird ausgelassen:# Fix typo in gatewaypi# Die Commit-Beschreibungsymfony#23 wird ausgelassen:# Fix typo# Die Commit-Beschreibungsymfony#24 wird ausgelassen:# Update README.md
derrabus pushed a commit to derrabus/symfony that referenced this pull requestJul 25, 2023
This PR was merged into the 1.3-dev branch.Discussion----------Use adapter for UploadedFile objectsReplacessymfony#68,fixessymfony#15,symfony#39Commits-------a4f9f6d Use adapter for UploadedFile objects
chalasr added a commit that referenced this pull requestMar 5, 2024
…lishing a message. (jwage)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Messenger] [Amqp] Handle AMQPConnectionException when publishing a message.| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#36538Fix#48241| License | MITIf you have a message handler that dispatches messages to another queue, you can encounter `AMQPConnectionException` with the message "Library error: a SSL error occurred" or "a socket error occurred" depending on if you are using tls or not or if you are running behind a load balancer or not.You can manually reproduce this issue by dispatching a message where the handler then dispatches another message to a different queue, then go to rabbitmq admin and close the connection manually, then dispatch another message and when the message handler goes to dispatch the other message, you will get this exception:```a socket error occurred#0 /vagrant/vendor/symfony/amqp-messenger/Transport/AmqpTransport.php(60): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpSender->send()#1 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(62): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransport->send()#2 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle()#3 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(61): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle()#4 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle()#5 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle()#6 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle()#7 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle()#8 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch()#9 /vagrant/src/Messenger/MessageBus.php(37): Symfony\Component\Messenger\TraceableMessageBus->dispatch()#10 /vagrant/vendor/symfony/mailer/Mailer.php(66): App\Messenger\MessageBus->dispatch()#11 /vagrant/src/Mailer/Mailer.php(83): Symfony\Component\Mailer\Mailer->send()#12 /vagrant/src/Mailer/Mailer.php(96): App\Mailer\Mailer->send()#13 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(118): App\Mailer\Mailer->sendEmail()#14 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(72): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->handle()#15 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(152): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->__invoke()#16 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(91): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->callHandler()#17 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(71): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->handle()#18 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle()#19 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(68): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle()#20 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle()#21 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle()#22 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle()#23 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle()#24 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch()#25 /vagrant/vendor/symfony/messenger/RoutableMessageBus.php(54): Symfony\Component\Messenger\TraceableMessageBus->dispatch()#26 /vagrant/vendor/symfony/messenger/Worker.php(162): Symfony\Component\Messenger\RoutableMessageBus->dispatch()#27 /vagrant/vendor/symfony/messenger/Worker.php(109): Symfony\Component\Messenger\Worker->handleMessage()#28 /vagrant/vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(238): Symfony\Component\Messenger\Worker->run()#29 /vagrant/vendor/symfony/console/Command/Command.php(326): Symfony\Component\Messenger\Command\ConsumeMessagesCommand->execute()#30 /vagrant/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run()#31 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(126): Symfony\Component\Console\Application->doRunCommand()#32 /vagrant/vendor/symfony/console/Application.php(324): Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand()#33 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(80): Symfony\Component\Console\Application->doRun()#34 /vagrant/vendor/symfony/console/Application.php(175): Symfony\Bundle\FrameworkBundle\Console\Application->doRun()#35 /vagrant/vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php(49): Symfony\Component\Console\Application->run()#36 /vagrant/vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run()#37 /vagrant/bin/console(11): require_once('...')#38 {main}```TODO:- [x] Add test for retry logic when publishing messagesCommits-------f123370 [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message.
nicolas-grekas added a commit that referenced this pull requestSep 28, 2024
…adFromProcess` (fritzmg)This PR was merged into the 5.4 branch.Discussion----------[Console] Suppress `proc_open` errors within `Terminal::readFromProcess`| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues || License | MITWhen instantiating `SymfonyStyle` in a command it will try to determine the maximum width of the current console interface.https://github.com/symfony/symfony/blob/6687e4ea35f45ebd73fb0315938103628cfb13a0/src/Symfony/Component/Console/Style/SymfonyStyle.php#L53This will execute `stty -a | grep columns` down the line. Access to `stty` might be disallowed however, resulting in the following error:```ErrorException: Warning: proc_open(): Exec failed: Permission denied#16 /vendor/symfony/console/Terminal.php(220): Symfony\Component\Console\Terminal::readFromProcess#15 /vendor/symfony/console/Terminal.php(204): Symfony\Component\Console\Terminal::getSttyColumns#14 /vendor/symfony/console/Terminal.php(170): Symfony\Component\Console\Terminal::initDimensionsUsingStty#13 /vendor/symfony/console/Terminal.php(153): Symfony\Component\Console\Terminal::initDimensions#12 /vendor/symfony/console/Terminal.php(94): Symfony\Component\Console\Terminal::getWidth#11 /vendor/symfony/console/Style/SymfonyStyle.php(55): Symfony\Component\Console\Style\SymfonyStyle::__construct#10 /vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(136): Symfony\Component\Messenger\Command\ConsumeMessagesCommand::interact#9 /vendor/symfony/console/Command/Command.php(311): Symfony\Component\Console\Command\Command::run```(Stack Trace actually from Symfony 6)The phpDoc of `Terminal::getSttyColumns` states> Runs and parses stty -a if it's available, _suppressing any error output_.The latter might refer to `['suppress_errors' => true]` (though I am not sure) - which is a Windows only functionality. In any case, since `Terminal::readFromProcess` already checks for```phpif (!$process = proc_open(…)) { return null;}```and```phpif (!\is_resource($process)) { return null;}```upstream in Symfony 6/7, indicating that `proc_open` might fail - this error can additionally be suppressed using `@`. Besides, `Process::start` also uses ``@proc_open`` (added in099481f "Prevent warning in proc_open()").Commits-------575249a suppress proc_open errors
stobrien89 pushed a commit to stobrien89/symfony that referenced this pull requestFeb 27, 2025
…ming-patternsDocument service naming patterns
This pull request wasclosed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught an error in WebProfiler page like below.
Fatal error: Call to a member function getRawValue() on a non-object in /path-to-sandbox/src/vendor/symfony/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/request_panel.php on line 45
When the session attributes don't exist, $data->sessionAttributes->getRawValue() cannot be called as not being defined.
So I added the check whether the session attributes exist or not before calling getRawValue().