Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Profiler][Translation] added filter.#14993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aitboudad commentedJun 15, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | ~ |
| Tests pass? | yes |
| License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a better name would befilter ortype_filter rather thanvalue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
btw, it is not really a message-type filter. It is a state filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed and thanks for your feedback :)
8583da5 to65f9291Comparestof commentedJun 15, 2015
👍 |
fabpot commentedJun 15, 2015
Thank you@aitboudad. |
This PR was merged into the 2.8 branch.Discussion----------[Profiler][Translation] added filter.| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Fixed tickets | ~| Tests pass? | yes| License | MITCommits-------65f9291 [Profiler][Translation] added filter.
rvanlaak commentedJun 22, 2015
👍 |