Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Do not trigger deprecation error in ResolveParameterPlaceHoldersPass#14988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
murnieza commentedJun 15, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | none |
| License | MIT |
| Doc PR | none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is no longer required, see#14900.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes it is! We still have to trigger the relevant notices, and only them. Silencing can be turned off (and will be by users preparing for 3.0 migration).
nicolas-grekas commentedJun 15, 2015
I voted too quickly, removing it for now. When this code path is taken, it means one is using a deprecated service factories configuration. Why should we hide the notice? To me, there is something to upgrade, thus to warn about. Did I miss something? |
stof commentedJun 15, 2015
@nicolas-grekas but you already got the notice in the place using it. This will trigger a second notice in a place out of the control of the user |
stof commentedJun 15, 2015
btw, the call to |
nicolas-grekas commentedJun 15, 2015
@stof true, thanks for the review! 👍 then |
fabpot commentedJun 15, 2015
Thank you@murnieza. |
…eHoldersPass (murnieza)This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#14988).Discussion----------Do not trigger deprecation error in ResolveParameterPlaceHoldersPass| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | noneCommits-------600078a Do not trigger deprecation error in ResolveParameterPlaceHoldersPass