NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

Do not trigger deprecation error in ResolveParameterPlaceHoldersPass#14988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

murnieza wants to merge1 commit intosymfony:2.8frommurnieza:patch-1

Closed

Do not trigger deprecation error in ResolveParameterPlaceHoldersPass#14988

murnieza wants to merge1 commit intosymfony:2.8frommurnieza:patch-1

Conversation

Copy link

murnieza commentedJun 15, 2015

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	none
License	MIT
Doc PR	none

Do not trigger deprecation error in ResolveParameterPlaceHoldersPass

a3d4968

linaori reviewed

Jun 15, 2015

View reviewed changes

src/Symfony/Component/DependencyInjection/Compiler/ResolveParameterPlaceHoldersPass.php

		@@ -38,7 +38,7 @@ public function process(ContainerBuilder $container)
		$definition->setFile($parameterBag->resolveValue($definition->getFile()));
		$definition->setArguments($parameterBag->resolveValue($definition->getArguments()));
		if ($definition->getFactoryClass(false)) {
		$definition->setFactoryClass($parameterBag->resolveValue($definition->getFactoryClass()));
		$definition->setFactoryClass($parameterBag->resolveValue($definition->getFactoryClass(false)));

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is no longer required, see#14900.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes it is! We still have to trigger the relevant notices, and only them. Silencing can be turned off (and will be by users preparing for 3.0 migration).

nicolas-grekas added the Ready label

Jun 15, 2015

Copy link

Member

nicolas-grekas commentedJun 15, 2015

I voted too quickly, removing it for now. When this code path is taken, it means one is using a deprecated service factories configuration. Why should we hide the notice? To me, there is something to upgrade, thus to warn about. Did I miss something?

nicolas-grekas removed the Ready label

Jun 15, 2015

Copy link

Member

stof commentedJun 15, 2015

@nicolas-grekas but you already got the notice in the place using it. This will trigger a second notice in a place out of the control of the user

Copy link

Member

stof commentedJun 15, 2015

btw, the call tosetFactoryClass will also trigger a deprecation warning here, so you would even get 2 new warnings

Copy link

Member

nicolas-grekas commentedJun 15, 2015

@stof true, thanks for the review! 👍 then

nicolas-grekas added the Ready label

Jun 15, 2015

Copy link

Member

fabpot commentedJun 15, 2015

Thank you@murnieza.

fabpot closed this

Jun 15, 2015

fabpot added a commit that referenced this pull request

Jun 15, 2015

minor#14988Do not trigger deprecation error in ResolveParameterPlac…

4c800ae

…eHoldersPass (murnieza)This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#14988).Discussion----------Do not trigger deprecation error in ResolveParameterPlaceHoldersPass| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |  none| License       | MIT| Doc PR        | noneCommits-------600078a Do not trigger deprecation error in ResolveParameterPlaceHoldersPass