You need to make sure that core code does not trigger such deprecation though (for therequest service for instance).

and the loaders should trigger their own deprecations when usingscope to have a better message (same than done in a few other places)

@stof The only cases in the core code are therequest scope and thetest.client service with theprototype scope. What's the best approach?

@dosten As you can see on Travis, there are still many tests that need to be moved as legacy ones. For thetest.client, I think that we need to keep theprototype scope as it was done before the introduction of scopes. Back then, we had a flag for prototype. As we decided to call itfactory in Pimple (as this is where prototypes make more sense), I think we can add afactory flag which would replace theprototype scope.

@fabpot Thank you for your feedback, I didn't have enough time to continue with this PR. I'll work on this soon.
I've searched for the flag that you refer, and I have found this commit1d5b6ed. Are you refering to theshared flag?
IMO if we add afactory flag this would be confusing, we already have the concept of factories in the DI.shared is a good name IMO.

I've added a initial implementation of ashared flag in the service definition, so any service that sets this flag asfalse will return a new instance every time, like theprototype scope. There is many failing tests because the deprecation messages, but i want to discuss this before fix the tests.

I can't trigger an error on the methods of theContainerInterface because the BC promise, any idea?

@dosten I was indeed refering to the oldshared flag (and you are right that using factory like in Pimple is probably confusing). ping @symfony/deciders

shared makes sense to me.

@fabpot This PR is ready to be reviewed.

👍 good job

👍

@fabpot Comments addressed

Thank you@dosten.