Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.0][FrameworkBundle] Add assets helper#14972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dosten wants to merge1 commit intosymfony:masterfromdosten:framework-bundle/add-assets-helper
Closed

[3.0][FrameworkBundle] Add assets helper#14972

dosten wants to merge1 commit intosymfony:masterfromdosten:framework-bundle/add-assets-helper

Conversation

dosten
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?yes
Deprecations?no
Tests pass?yes
LicenseMIT

This PR adds again theAssetsHelper removed in#13666 but without the BC layer. Without this helper we can't use the Asset component in a PHP template.
If all of us agree with this, we should fix the UPGRADE-2.7.md file updated in#14940

@dosten
Copy link
ContributorAuthor

Hmm Travis didn't run in this PR.

@wouterj
Copy link
Member

Please be aware that there is a very high change that PHP templating support will be removed from core in Symfony 3.

@dosten
Copy link
ContributorAuthor

Yes, i'm aware of that, but while we discuss if the templating support is removed or not i want to keep this here.

@peterrehm
Copy link
Contributor

And this it the wrong helper IMHO, if you look at the docshttp://symfony.com/doc/current/components/templating/helpers/assetshelper.html the classSymfony\Component\Templating\Helper\AssetsHelper seems to be the important one. So due to the refactoring in the Asset component I would assume if php templating support remains, a helper should be placed in that Component.

@peterrehm
Copy link
Contributor

Also again I think the service will be replaced anyway, the discussion here is just about the helper.

I would recommend to close this PR here and continue the discussion in#14956

@dosten
Copy link
ContributorAuthor

IMO instead of continue the discussion here or#14956 we should continue the discussion in#12897

@dosten
Copy link
ContributorAuthor

Closing this in favor of drop the Templating component.

@dostendosten closed thisJun 15, 2015
@dostendosten deleted the framework-bundle/add-assets-helper branchJune 15, 2015 17:25
@wouterj
Copy link
Member

This should be reopened again. There currently is PHP templating support in Symfony 3 (dropping it was reverted), but there all helpers related to assets are removed.

@dostendosten restored the framework-bundle/add-assets-helper branchDecember 17, 2015 02:09
@dostendosten reopened thisDec 17, 2015
@dosten
Copy link
ContributorAuthor

@wouterj I'm going to see if I can restore al the code related to the Templating component, but we should merge this in 3.1 or in 3.0 as a bug fix?

@dostendosten closed thisDec 17, 2015
@dostendosten deleted the framework-bundle/add-assets-helper branchDecember 17, 2015 03:39
@dosten
Copy link
ContributorAuthor

closed in favour of#17041

fabpot added a commit that referenced this pull requestJan 19, 2016
This PR was merged into the 3.0 branch.Discussion----------[FrameworkBundle] Added the assets helper again| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITThis PR is a follow up of#14972, we deprecated and removed the AssetsHelper in 2.7/3.0 doing impossible to use the Asset component and the PHP templates together, I've submitted this PR to be merged in 3.0 because IMO this is a bug fix, but we documented the deprecation and removal of the helper, what we should do here? (https://github.com/symfony/symfony/blob/3.0/UPGRADE-3.0.md#frameworkbundle andhttps://github.com/symfony/symfony/blob/2.8/UPGRADE-2.7.md#frameworkbundle)cc/@wouterjCommits-------98cb838 Added the assets helper again
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dosten@wouterj@peterrehm
[8]ページ先頭
©2009-2025 Movatter.jp