Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Documented minor BC break introduced in AssetHelper#14940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
peterrehm wants to merge2 commits intosymfony:2.7frompeterrehm:assets-helper
Closed

Documented minor BC break introduced in AssetHelper#14940

peterrehm wants to merge2 commits intosymfony:2.7frompeterrehm:assets-helper

Conversation

peterrehm
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#14898
LicenseMIT
Doc PR-

This should be an easy fix. As this AssetHelper is removed in 3.0 I think no correction for 3.0 would be needed.

@stof
Copy link
Member

👍

1 similar comment
@xabbuh
Copy link
Member

👍

@fabpot
Copy link
Member

That's really just a hack to make things work. So, we should probably trigger some error notices when methods from the old class are called. And anyway, calling any of these methods will lead to some fatal errors as the original constructor is not called, so the properties are not initialized.

👎

@peterrehm
Copy link
ContributorAuthor

There are several ways how this could adjusted further:

  1. Overwrite the other methods of the old service and trigger deprecation messages
  2. Try to return the old service
  3. Accept the minor BC break (It looks like it does not affect many at all) and just add that to the upgrade description

@fabpot
Copy link
Member

3 looks like the better idea.

@peterrehm
Copy link
ContributorAuthor

@fabpot Just updated. I am wondering if I updated that correctly, will thetemplating.helper.assets really be removed in 3.0. It is still in the template_php.xml but the actual helper class is not any more there in the master branch.

I assumed this for now and would update accordingly, the way as it was phrased before recommended anyway the use of theasset.packages service.

@peterrehmpeterrehm changed the titleFixed BC break introduced in AssetHelperDocument minor BC break introduced in AssetHelperJun 11, 2015
@peterrehmpeterrehm changed the titleDocument minor BC break introduced in AssetHelperDocumented minor BC break introduced in AssetHelperJun 11, 2015
@fabpot
Copy link
Member

👍

@fabpot
Copy link
Member

Thank you@peterrehm.

fabpot added a commit that referenced this pull requestJun 11, 2015
…errehm)This PR was squashed before being merged into the 2.7 branch (closes#14940).Discussion----------Documented minor BC break introduced in AssetHelper| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#14898| License       | MIT| Doc PR        | -This should be an easy fix. As this AssetHelper is removed in 3.0 I think no correction for 3.0 would be needed.Commits-------777dc45 Documented minor BC break introduced in AssetHelper
@fabpotfabpot closed thisJun 11, 2015
@peterrehmpeterrehm deleted the assets-helper branchJune 12, 2015 00:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@peterrehm@stof@xabbuh@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp