Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Documented minor BC break introduced in AssetHelper#14940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👍 |
1 similar comment
👍 |
That's really just a hack to make things work. So, we should probably trigger some error notices when methods from the old class are called. And anyway, calling any of these methods will lead to some fatal errors as the original constructor is not called, so the properties are not initialized. 👎 |
There are several ways how this could adjusted further:
|
3 looks like the better idea. |
@fabpot Just updated. I am wondering if I updated that correctly, will the I assumed this for now and would update accordingly, the way as it was phrased before recommended anyway the use of the |
👍 |
Thank you@peterrehm. |
…errehm)This PR was squashed before being merged into the 2.7 branch (closes#14940).Discussion----------Documented minor BC break introduced in AssetHelper| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#14898| License | MIT| Doc PR | -This should be an easy fix. As this AssetHelper is removed in 3.0 I think no correction for 3.0 would be needed.Commits-------777dc45 Documented minor BC break introduced in AssetHelper
This should be an easy fix. As this AssetHelper is removed in 3.0 I think no correction for 3.0 would be needed.