Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] trigger a deprecation warning when using the ContainerAwareHttpKernel#14665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:2.7fromxabbuh:container-aware-kernel-deprecateion-triggerMay 20, 2015
Merged
[HttpKernel] trigger a deprecation warning when using the ContainerAwareHttpKernel#14665
fabpot merged 1 commit intosymfony:2.7fromxabbuh:container-aware-kernel-deprecateion-triggerMay 20, 2015
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedMay 20, 2015
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestMay 20, 2015
…e ContainerAwareHttpKernel (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[HttpKernel] trigger a deprecation warning when using the ContainerAwareHttpKernel| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#13280| License | MIT| Doc PR |I agree that we should not trigger the deprecation warning when the `ContainerAwareHttpKernel` is used in the framework code. However, developers using this class in their own code should receive a warning to be able to prepare their applications for Symfony 3.0.Commits-------030731a [HttpKernel] trigger a deprecation warning when using the ContainerAwareHttpKernel
Tobion added a commit that referenced this pull requestDec 13, 2015
…eprecation flag (ogizanagi)This PR was merged into the 3.0 branch.Discussion----------[FrameworkBundle][HttpKernel] Remove remaining $triggerDeprecation flag| Q | A| ------------- | ---| Fixed tickets | n/a| License | MITIntroduced in#14665, this flag controlled the deprecation notice triggering when using the `ContainerAwareHttpKernel`, in order to avoid triggering it when using this class in the Symfony framework. This class no longer exists now, neither the flag.Commits-------ac15454 [FrameworkBundle][HttpKernel] Remove remaining $triggerDeprecation flag
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I agree that we should not trigger the deprecation warning when the
ContainerAwareHttpKernelis used in the framework code. However, developers using this class in their own code should receive a warning to be able to prepare their applications for Symfony 3.0.