Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fix QuestionHelperTest#14638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Console] Fix QuestionHelperTest#14638
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedMay 15, 2015
Looks like the problem is also present in older branches, right? In which case, this should be merged in the right branch. |
ogizanagi commentedMay 15, 2015
@fabpot : Actually, both Regarding the changeL206, you're right, this could have been done in the 2.6 branch. It doesn't even have a link with this issue. It was just an unreachable assert (or at least useless if reached, because what matters is the Should I revert this line and submit another PR for this change only, or is there anything else I missed which should be targeted in the 2.6 branch ? |
fabpot commentedMay 16, 2015
@ogizanagi Yes, can you submit a PR on 2.6? |
- When using the `InputInterface` mock with interactive option, asking a ChoiceQuestion without specifying max attempts nor a default value ledto an infinite loop when invalid values are submitted. In case there issomething wrong in tests, it wasn't obvious to understand what'shappening, as the process was constantly waiting for inputs.- `testAmbiguousChoiceFromChoicelist` test was wrong as the autocompleter filled the value and the test was never triggered (+maxattempt issue).
ogizanagi commentedMay 16, 2015
fabpot commentedMay 16, 2015
Thank you@ogizanagi. |
This PR was merged into the 2.7 branch.Discussion----------[Console] Fix QuestionHelperTest| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This PR fixes the following issues in `QuestionHelperTest`:- When using the `InputInterface` mock with interactive option, asking a ChoiceQuestion without specifying max attempts nor a default value led to an infinite loop when invalid values are submitted. In case there is something wrong in tests, it wasn't obvious to understand what's happening, as the process was constantly waiting for inputs.- `testAmbiguousChoiceFromChoicelist` test was wrong as the autocompleter filled the value and the test was never triggered (+max attempt issue).Commits-------6a0308d [Console] Fix QuestionHelperTest
This PR was merged into the 2.7 branch.Discussion----------[Console] Set QuestionHelper max attempts in testsOtherwise the process will block if a test fails.| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -QuestionHelper tests will block the phpunit process if any of tests fails. This is what's currently happening on 2.8 branch. As soon as this is merged to 2.7 and 2.8, I can work on fixing 2.8 tests.re#14638Commits-------23bc264 [Console] Set QuestionHelper max attempts in tests
This PR fixes the following issues in
QuestionHelperTest:InputInterfacemock with interactive option, asking a ChoiceQuestion without specifying max attempts nor a default value led to an infinite loop when invalid values are submitted. In case there is something wrong in tests, it wasn't obvious to understand what's happening, as the process was constantly waiting for inputs.testAmbiguousChoiceFromChoicelisttest was wrong as the autocompleter filled the value and the test was never triggered (+max attempt issue).