Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[3.0][HttpKernel] remove deprecated functions and classes#14634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[3.0][HttpKernel] remove deprecated functions and classes#14634
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vincentaubert commentedMay 14, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
Hello, I have a problem with the dependency injection of the Framework bundle. in the services.xml file in the framework bundle I got this : But the Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel class is marked as deprecated in the HttpKernel component. By what should I replace this class to make it work ? Thanks |
38c523c tod98acacCompare@vincentaubert You can use |
You should replace it by |
Thanks |
| @@ -75,7 +75,7 @@ public function testLogNonUtf8() | |||
| public function testLogLongString() | |||
| { | |||
| $logger = $this->getMock('Symfony\\Component\\HttpKernel\\Log\\LoggerInterface'); | |||
| $logger = $this->getMock('Psr\\Log\\LoggerInterface'); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change and the next one should happen in Symfony 2.7 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done in PR#14637
aaf7e51 tofcfdafaCompareping @symfony/mergers This PR is ready for merge. The 2 failing tests have been fixed in the 2.7 branch via the#14637 PR but the 2.7 branch hasn't been merged in master at the moment. I launched the tests locally with the patch and all the tests passed |
|
fcfdafa to1195613Comparefixed thanks |
| @@ -200,10 +200,8 @@ public function getDumps($format, $maxDepthLimit = -1, $maxItemsPerDepth = -1) | |||
| foreach ($this->data as $dump) { | |||
| if (method_exists($dump['data'], 'withMaxDepth')) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if to be removed also
1195613 to2a29119Comparedone and code rebased on the latest master |
| @@ -198,12 +198,6 @@ public function getDumps($format, $maxDepthLimit = -1, $maxItemsPerDepth = -1) | |||
| $dumps = array(); | |||
| foreach ($this->data as $dump) { | |||
| if (method_exists($dump['data'], 'withMaxDepth')) { | |||
| $dumper->dump($dump['data']->withMaxDepth($maxDepthLimit)->withMaxItemsPerDepth($maxItemsPerDepth)); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should keep this line!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
2a29119 to5bf6b0dCompare336016c toc19f918CompareThank you@vincentaubert. |
…ses (vincentaubert)This PR was merged into the 3.0-dev branch.Discussion----------[3.0][HttpKernel] remove deprecated functions and classes| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------c19f918 [3.0][HttpKernel] remove deprecated functions and classes
| @@ -67,34 +67,12 @@ public function __construct($matcher, RequestContext $context = null, LoggerInte | |||
| throw new \InvalidArgumentException('You must either pass a RequestContext or the matcher must implement RequestContextAwareInterface.'); | |||
| } | |||
| if (!$requestStack instanceof RequestStack) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
requestStack must be made required
…derrabus)This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes#225).Discussion----------Don't include ContainerAwareHttpKernel if it's not presentWhen generating the bootstrap file, the composer script handler also includes `Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel`, a class that has been removed with PRsymfony/symfony#14634 and that will be gone in Symfony 3.0.This pull request checks if the class is present and includes `Symfony\Component\HttpKernel\HttpKernel` otherwise. The code should work with Symfony 2.7 as well as with 3.0-dev.Commits-------2e45487 Don't include ContainerAwareHttpKernel if it's not present.
…ion)This PR was merged into the 3.0-dev branch.Discussion----------[HttpKernel] make RequestStack parameter required| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aContinuation of#14634,#8904Commits-------a2e154d [HttpKernel] make RequestStack parameter required for classes that need it
This PR was merged into the 3.3 branch.Discussion----------[HttpKernel] Remove isset call used for legacy| Q | A| ------------- | ---| Branch? | 3.3 <!-- see comment below -->| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AAdded in#9628 in which the request stack dependency was nullable. Forgotten to be removed in#14634.Commits-------e0a6010 [HttpKernel] Remove isset call used for legacy