NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] use ConfigCache::getPath() method when it exists#14610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.7fromxabbuh:config-cache-deprecations

May 11, 2015

Merged

[HttpKernel] use ConfigCache::getPath() method when it exists#14610

fabpot merged 1 commit intosymfony:2.7fromxabbuh:config-cache-deprecations

May 11, 2015

Conversation

Copy link

Member

xabbuh commentedMay 11, 2015

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

This way, the deprecated__toString() method of theConfigCache
class will not be called.

[HttpKernel] use ConfigCache::getPath() method when it exists

ab70632

This way, the deprecated `__toString()` method of the `ConfigCache`class will not be called.

xabbuh force-pushed theconfig-cache-deprecations branch from215c42b toab70632Compare

May 11, 2015 16:42

Copy link

Contributor

aitboudad commentedMay 11, 2015

👍 wouldn't be better to useConfigCacheFactory too.

Copy link

MemberAuthor

xabbuh commentedMay 11, 2015

@aitboudad The instance is passed to the method. What exactly do you propose to change there?

Copy link

Member

fabpot commentedMay 11, 2015

Thank you@xabbuh.

fabpot merged commitab70632 intosymfony:2.7

May 11, 2015

fabpot added a commit that referenced this pull request

May 11, 2015

minor#14610[HttpKernel] use ConfigCache::getPath() method when it e…

bdcce21

…xists (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[HttpKernel] use ConfigCache::getPath() method when it exists| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |This way, the deprecated `__toString()` method of the `ConfigCache`class will not be called.Commits-------ab70632 [HttpKernel] use ConfigCache::getPath() method when it exists

Copy link

Contributor