Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] use ConfigCache::getPath() method when it exists#14610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromxabbuh:config-cache-deprecations
May 11, 2015

Conversation

xabbuh
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

This way, the deprecated__toString() method of theConfigCache
class will not be called.

This way, the deprecated `__toString()` method of the `ConfigCache`class will not be called.
@xabbuhxabbuhforce-pushed theconfig-cache-deprecations branch from215c42b toab70632CompareMay 11, 2015 16:42
@aitboudad
Copy link
Contributor

👍 wouldn't be better to useConfigCacheFactory too.

@xabbuh
Copy link
MemberAuthor

@aitboudad The instance is passed to the method. What exactly do you propose to change there?

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commitab70632 intosymfony:2.7May 11, 2015
fabpot added a commit that referenced this pull requestMay 11, 2015
…xists (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[HttpKernel] use ConfigCache::getPath() method when it exists| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |This way, the deprecated `__toString()` method of the `ConfigCache`class will not be called.Commits-------ab70632 [HttpKernel] use ConfigCache::getPath() method when it exists
@aitboudad
Copy link
Contributor

@xabbuh see#14178.

@xabbuhxabbuh deleted the config-cache-deprecations branchMay 11, 2015 17:45
@xabbuh
Copy link
MemberAuthor

@aitboudad#14178 is already merged, isn't it?

@aitboudad
Copy link
Contributor

@xabbuh yes, but I think we have forgotten to apply the changes inkernel

@xabbuh
Copy link
MemberAuthor

@aitboudad I'm afraid I still don't understand what you mean. Maybe it's better if you create a PR. :)

@aitboudad
Copy link
Contributor

@xabbuh 😄 ok I'll try

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@xabbuh@aitboudad@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp